Skip to content

Fix docker build issues and add pipeline for docker images.#431

Merged
Williangalvani merged 8 commits intoArduPilot:masterfrom
bedaberner:master
May 16, 2025
Merged

Fix docker build issues and add pipeline for docker images.#431
Williangalvani merged 8 commits intoArduPilot:masterfrom
bedaberner:master

Conversation

@bedaberner
Copy link
Contributor

@bedaberner bedaberner commented Apr 23, 2025

I run into some issues when trying to build the docker image (see #414).

While fixing them, I also added a pipeline that automatically builds the docker image and publishes it to githubs integrated docker registry.

@bedaberner
Copy link
Contributor Author

@Williangalvani
could you take a look at this?

@igoutta
Copy link

igoutta commented May 14, 2025

This is a must, since the current Dockerfile doesn't work and doing it manually ends in error since everything is deprecated and asks for a replacement or fix. I have some suggestion:

  • Use apt instead of apt-get, since Ubuntu and Debian adopted this package manager.
  • git install command should be asked if needed, since some VMs could have that package integrated.

Genuinely, I thank you for this update.

Copy link
Collaborator

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. thanks for the contribution!

@Williangalvani Williangalvani merged commit 469b470 into ArduPilot:master May 16, 2025
2 checks passed
@ericcater
Copy link

Just found this project a hour ago and am having issues that seem topical to this pull request. I can't pull the image, it's saying 403 forbidden. I can see that the image was pushed in the actions job. Haven't built/pushed images with github actions in a while and am not familar with permissions, but I don't think that's necessarily it.

Is anyone able to pull the image? It's also wanting the image name to be lowercase.

docker: invalid reference format: repository name (ArduPilot/UAVLogViewer) must be lowercase

@bedaberner
Copy link
Contributor Author

You are totally right, there are 2 Issues:

  1. I used uppercase in the readme which does not work, I created a PR to fix this: fixed docker reference to be lower case #434
  2. The Pipeline only uploads the image to ghcr for releases, for merges into main, it only checks if the image is buildable. Since no release happend since yesterday (when this was merged), there is no image yet you can pull.

If you just want to pull an image, you can use my fork until this is fixed here: ghcr.io/bedaberner/uavlogviewer:latest

@Williangalvani
Copy link
Collaborator

almost there. I think the last remaining issue is that I lack permission to make the package public. working on that.

@bedaberner bedaberner mentioned this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants