Merged
Conversation
Contributor
|
I looks like this was applied to the master branch rather than the v4alpha branch where it belonged - thats why there were so many conflicts. |
Taynarafernandes42
force-pushed
the
thermal_use
branch
from
f69d7a3 to
a99f09b
Compare
Author
|
Hi Casper, I've updated the thermal use module with some bug fixes and improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new thermal use module that enables GLM to simulate heat extraction from lakes, such as for heat pump applications or other thermal energy systems.
This is a draft PR because there are merge conflicts that need to be resolved. The conflicts appear to be related to other updates that occurred in the v4alpha branch after my development began.
New module files: glm_heatexchange.c and glm_heatexchange.h, containing the core thermal use functionality
Integration changes: Updates to existing GLM files to incorporate the heat exchange module into the simulation workflow.
The core functionality has been tested, but I want to ensure it integrates cleanly with the latest codebase changes before marking this ready for review.