⚡ Bolt: Optimize yEnc decoding with bytes.translate

[xbmc4lyfe]

💡 What: Optimize yEnc payload decoding by replacing the byte-by-byte Python iteration with C-backed bytes.translate() and bytes.find() calls.

🎯 Why: Iterating over bytes manually inside a Python while loop is extremely slow due to the interpreter overhead on every iteration. Offloading the work to C modules allows for massive performance gains in byte string operations.

📊 Impact: ~10x speedup for decoding yEnc data, reducing the time spent in _decode_yenc_lines from ~0.17s down to ~0.017s per megabyte according to local benchmark.

🔬 Measurement: Benchmark script parsing chunks of 1MB dummy data:

• Old time: 0.1715s
• New time: 0.0178s
• Speedup: 9.62x

---

PR created automatically by Jules for task 11756253195750969450 started by @xbmc4lyfe

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 135f167a-054c-432e-b6ef-09d8905080a6

📥 Commits

Reviewing files that changed from the base of the PR and between 0de7ede and 2d79361.

📒 Files selected for processing (2)

• .jules/bolt.md
• verify_nzb.py

📜 Recent review details

⏰ Context from checks skipped due to timeout. (1)

• GitHub Check: Codacy Static Code Analysis

🧰 Additional context used

🪛 GitHub Check: Codacy Static Code Analysis

.jules/bolt.md

[notice] 1-1: .jules/bolt.md#L1
Expected: 1; Actual: 0; Below

verify_nzb.py

[warning] 289-289: verify_nzb.py#L289
Operator "<" not supported for "None" (reportOptionalOperand)

🔇 Additional comments (3)

verify_nzb.py (2)

118-135: LGTM!

---

146-148: LGTM!

Also applies to: 245-247, 283-289, 311-313, 431-444, 459-461, 521-523, 551-553, 565-569, 583-597, 623-626, 677-679, 707-709, 791-794, 803-805, 872-874, 887-893, 906-918

.jules/bolt.md (1)

1-4: LGTM!

---

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Improved yEnc decoding performance, making NZB verification faster on large or dense messages.
• Bug Fixes
  • Preserved existing yEnc escape handling and validation behavior while improving decoding speed.
  • Added a clearer warning note about the decoding performance improvement.
• Refactor
  • Updated several internal control-flow and command-line handling paths without changing user-facing behavior.

Walkthrough

This PR optimizes yEnc byte decoding in verify_nzb.py using a precomputed translation table with bytes.translate/bytes.find, normalizes input line encoding in validate_yenc_body, adds a documentation note about the change, and reformats numerous unrelated expressions across the file into multiline forms without altering behavior.

Changes

yEnc Decoding and Code Formatting

Layer / File(s)	Summary
yEnc decoding performance optimization verify_nzb.py, .jules/bolt.md	Adds _YENC_TRANS_TABLE and rewrites _decode_yenc_lines to use bytes.translate/bytes.find instead of byte-by-byte loops, preserving dangling-escape error behavior; validate_yenc_body normalizes lines to bytes via latin-1 encoding; documents the change in a dated note.
Config validation and sampling formatting verify_nzb.py	Reformats select_deep_sample size computation and load_config error message construction into multiline expressions.
NNTP response reading exception handling verify_nzb.py	Groups connection-related exceptions into a single except (...) clause in _read_response and reformats _read_multiline's readline call.
Verifier worker scheduling formatting verify_nzb.py	Reformats _Verifier.run signature, stats aggregation, worker startup, worker loop, job selection, finalization call, and server index function into multiline forms.
Deep verifier and CLI formatting verify_nzb.py	Reformats _DeepVerifier.run's gather call, output writing, error result construction, verify_nzb's Verifier invocation, and build_arg_parser construction into multiline forms.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
    participant Caller as validate_yenc_body
    participant Decoder as _decode_yenc_lines
    participant Table as _YENC_TRANS_TABLE

    Caller->>Caller: normalize raw_line to bytes (latin-1)
    Caller->>Decoder: pass normalized line
    Decoder->>Table: bytes.translate(line)
    Decoder->>Decoder: bytes.find(escape marker)
    alt escape found
        Decoder->>Decoder: apply modulo arithmetic
    else trailing escape
        Decoder-->>Caller: raise ValueError("dangling yEnc escape")
    end
    Decoder-->>Caller: decoded bytes

Loading

Poem

A rabbit hopped through bytes so slow,
Then found a table, watch it go! 🐇
Translate, find, no loop delay,
Lines line up in neat array.
Multiline code, tidy and bright—
Thump thump thump, review's a delight! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	It clearly summarizes the main change: optimizing yEnc decoding with bytes.translate.
Description check	✅ Passed	The description matches the changeset and explains the yEnc decoding optimization and its performance impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bolt/yenc-opt-11756253195750969450

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch bolt/yenc-opt-11756253195750969450

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Not up to standards ⛔

🔴 Issues 1 high · 1 minor

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category	Results
ErrorProne	1 high
CodeStyle	1 minor

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}