Skip to content

Relogin on pass change #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-beezee merged 6 commits into from
Jul 22, 2025
Merged

Relogin on pass change #1396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
975680f
fix: login again on pass change
d-beezee Jul 22, 2025
a0ada6a
fix: invalidate Users tags on password update
sinatragianpaolo Jul 22, 2025
698bcfa
fix: remove invalidation of Users tags in patchUsersMe endpoint
d-beezee Jul 22, 2025
ddace8e
fix: destroy other sessions on password update
sinatragianpaolo Jul 22, 2025
c6ba0b6
fix: ensure other sessions are destroyed after password update
d-beezee Jul 22, 2025
dc2c97d
Merge pull request #1394 from AppQuality/login-on-pass-change
d-beezee Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/features/api/apiTags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ unguessApi.enhanceEndpoints({
providesTags: ['Preferences'],
},
patchUsersMe: {
invalidatesTags: ['Users'],
onQueryStarted: async (arg, { dispatch, queryFulfilled }) => {
await queryFulfilled;
if (!arg?.body?.password) {
dispatch(unguessApi.util.invalidateTags(['Users']));
}
},
},
putUsersMePreferencesBySlug: {
invalidatesTags: ['Preferences'],
Expand Down
98 changes: 53 additions & 45 deletions src/pages/Profile/FormPassword.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Notification, useToast } from '@appquality/unguess-design-system';
import { Formik } from 'formik';
import { useTranslation } from 'react-i18next';
import WPAPI from 'src/common/wpapi';
import { usePatchUsersMeMutation } from 'src/features/api';
import * as Yup from 'yup';
import { Loader } from './parts/cardLoader';
Expand All @@ -11,7 +12,7 @@ import { PasswordFormValues } from './valuesType';
export const FormPassword = () => {
const { t } = useTranslation();
const { addToast } = useToast();
const { isLoading } = useProfileData();
const { data, isLoading } = useProfileData();
const [updateProfile] = usePatchUsersMeMutation();

const initialValues: PasswordFormValues = {
Expand Down Expand Up @@ -55,60 +56,67 @@ export const FormPassword = () => {
validateOnChange
onSubmit={async (values, actions) => {
actions.setSubmitting(true);
updateProfile({
body: {
password: {
current: values.currentPassword,
new: values.newPassword,
try {
await updateProfile({
body: {
password: {
current: values.currentPassword,
new: values.newPassword,
},
},
},
})
.unwrap()
.then(() => {
}).unwrap();
await WPAPI.destroyOtherSessions();

const nonce = await WPAPI.getNonce();
await WPAPI.login({
username: data?.email || '',
password: values.newPassword,
security: nonce,
});

addToast(
({ close }) => (
<Notification
onClose={close}
type="success"
message={t('__PROFILE_PAGE_TOAST_SUCCESS_PASSWORD_UPDATED')}
isPrimary
/>
),
{ placement: 'top' }
);
} catch (e) {
const error = e as { status: number; data: { message: string } };
if (error.status === 417) {
addToast(
({ close }) => (
<Notification
onClose={close}
type="success"
message={t('__PROFILE_PAGE_TOAST_SUCCESS_PASSWORD_UPDATED')}
type="error"
message={t(
'__PROFILE_PAGE_TOAST_ERROR_INVALID_CURRENT_PASSWORD'
)}
isPrimary
/>
),
{ placement: 'top' }
);
})
.catch((error) => {
if (error.status === 417) {
addToast(
({ close }) => (
<Notification
onClose={close}
type="error"
message={t(
'__PROFILE_PAGE_TOAST_ERROR_INVALID_CURRENT_PASSWORD'
)}
isPrimary
/>
),
{ placement: 'top' }
);
} else {
addToast(
({ close }) => (
<Notification
onClose={close}
type="error"
message={t('__PROFILE_PAGE_TOAST_ERROR_UPDATING_PASSWORD')}
isPrimary
/>
),
{ placement: 'top' }
);
}
})
.finally(() => {
actions.setSubmitting(false);
});
} else {
addToast(
({ close }) => (
<Notification
onClose={close}
type="error"
message={t('__PROFILE_PAGE_TOAST_ERROR_UPDATING_PASSWORD')}
isPrimary
/>
),
{ placement: 'top' }
);
}
} finally {
actions.setSubmitting(false);
}
}}
>
<PasswordAccordion />
Expand Down
Loading