Skip to content

Comments

New Release Join page and other 2025-06-11#1339

Merged
d-beezee merged 49 commits intomasterfrom
develop
Jun 11, 2025
Merged

New Release Join page and other 2025-06-11#1339
d-beezee merged 49 commits intomasterfrom
develop

Conversation

@iacopolea
Copy link
Member

@iacopolea iacopolea commented Jun 11, 2025

Rimozione Express, Aggiunta pagina Join

Configuration Updates:

  • Replaced .prettierrc.json with prettier.config.js, adding support for overrides and maintaining the same formatting rules. ([[1]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-979a4a52db5287c891eac28a141bfa97bf8b0732ed5afae848d90956ef80e78dL1-L19), [[2]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-e42472dd65561fe56344281078077fb924cddca92821eadfbc2318cca3f89c9aR1-R27))

Code Cleanup:

  • Removed unused reducers (expressReducer) from src/app/store.ts. ([[1]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-efbc9c2c3c62a72fb9d047216d1c0ed4a8223e51ce11cbcbb30a7a0a6049d042L7), [[2]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-efbc9c2c3c62a72fb9d047216d1c0ed4a8223e51ce11cbcbb30a7a0a6049d042L20))
  • Deleted unused components, such as HubspotModal, HuspotProvider, StickyContainer, and others, to clean up the codebase. ([[1]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-44a6b1f78e36ac2abd6cc396541fb5b0d7542b6040387faa0013d1febe379938L1-L62), [[2]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-52010651d465f16a1e56ae8439302644a0a0381f79ee835eeb227be3baad4b31L1-L46), [[3]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-7c825e07adfc6dd571a953d415a45b5f8bac6542f3adb741224a8f89309936cbL1-L11), [[4]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-edc03ec6d49f388f33f1220a8dedf768cdf5440bf937e854ae366391863da4ceL1-L10), [[5]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-ecbaa48253030af01862102a76a48f39f53f0c79dc86d0e7615177ebeca96a41L1-L10))
  • Simplified and refactored styled components, removing unnecessary exports and restructuring them as constants. ([[1]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-8e5cf458434703d9318a410f00bf67712cbabf868b84ef69d3f88ea08a1edc9cL14-R11), [[2]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-8e5cf458434703d9318a410f00bf67712cbabf868b84ef69d3f88ea08a1edc9cL69-L74), [[3]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-189614017373f94616aa00c9cca6a28ac1ceed763f77939edb475cd93ae64871L13-L25), [[4]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-869fe961e1855ce175958e38c92a6b6451225830d2c23392c30d5cb7cd1a7742L10-R10))

Dependency and Library Updates:

  • Added motion library to package.json for animation-related functionality. ([package.jsonR17](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R17))

Feature Enhancements:

  • Added a new JoinPage route and its corresponding logic to support user invitations and redirects. (Fc141141L17R16, [[1]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-18b8c2883244e54eda6e4b87feb09ec7931fbc94d26673f1310fe1a727cace31R70-R75), [[2]](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-18b8c2883244e54eda6e4b87feb09ec7931fbc94d26673f1310fe1a727cace31R156-R170))
  • Updated GoogleTagManager to include new fields (customer_role, profile_id) for enhanced data tracking. ([src/common/GoogleTagManager.tsxR44-R46](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-abc0f584cfeadd941d702121efa5ff1ac2f87a3cd389b69ecc00670e2127bfbeR44-R46))

Accessibility Improvement:

  • Added a title attribute to the loading image in index.html to improve accessibility. ([index.htmlL51-R51](https://github.com/AppQuality/unguess-react/pull/1339/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051L51-R51))

iacopolea and others added 30 commits May 15, 2025 16:19
refactor: remove ExpressWizard and Services
fix(CampaignWidgets): correctly show to go plan link and improve layo…
…mprove layout and spacing in the NavItem component.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
UN-1452 fix(TemplateCardsGrid): ensure UserTag only displays valid output
d-beezee and others added 19 commits June 6, 2025 09:47
Un 1438 - Aggiungere ruolo nel data layer utente
fix(Goal, OutOfScope): set minimum rows for text areas
refactor: Remove ButtonWrapper from JoinPage and update logged-in user tests

fix: Update JoinPage navigation logic to use searchParams for redirection and enhance tests for logged-in user scenarios

feat(api): add new endpoints for invites and user roles, and modify existing ones

- Added `getInvitesByProfileAndToken` query to fetch invites based on profile and token.
- Introduced `deleteProjectsByPid` mutation for deleting projects by ID.
- Added `headUsersByEmailByEmail` mutation to check for users by email.
- Added `getUsersRoles` query to retrieve user roles.
- Removed `postVideosByVidSentiment` mutation as it is no longer needed.
- Updated types for new endpoints and modified existing types for clarity.

test: Enhance Join page tests with setup for new user scenario

feat(join): add invite handling and loading state to JoinPage, update tests

WIP

feat: Implement multi-step join form with validation and navigation

- Refactored FormProvider to manage form state and validation using Formik and Yup.
- Created JoinForm component to render different steps based on the current step.
- Added Step1, Step2, and Step3 components for the multi-step join process.
- Integrated translation support for form validation messages.
- Updated JoinPage layout to include a grid structure for form and image.
- Removed obsolete Join fixture and added new step-specific fixtures for testing.

Implement code changes to enhance functionality and improve performance

feat(join): update JoinForm to handle invitation logic and enhance Step 2 UI

fix(join): update Step2 input disabled logic to prevent editing when invited

feat(join): enhance Step 1 with form fields and validation, update tests

fix(join): reset initial step to 1 in FormProvider and update test for Step 1 visibility

feat(join): implement dynamic validation for  password fields in Step 1, enhance test coverage for password requirements

feat(tests): add JSON test data for pending review plans and user roles

feat(join): add email validation logic in Step 1 and enhance test coverage for email inputs

fix(join): rename goToStep2 to buttonGoToStep2 for consistency and update goToNextStep method

feat(join): enhance Step 2 with role selection and validation, update Step 1 and Step 3 for consistency

feat(join): add validation for email input in Step 1 and update tests for button navigation

test(join): ensure password validation triggers on button click in Step 1

feat(api): replace postCampaigns with postUsers endpoint and update related types

fix(join): rename mail to email in JoinFormValues and update related references

feat(join): add status and values to useFormikContext and disable email input for invited users

feat(join): enhance Step1 and Step2 components with type safety and improve invited user handling in tests

feat(join): refactor form handling and validation, integrate new submission logic and improve user experience across steps

feat(join): refactor FormProvider and useJoinSubmit to streamline invited user handling; update tests for Step3 integration

feat(join): enhance Step2 component with improved role selection handling and validation; update tests for invited user scenarios

feat(join): add password visibility toggle to Step1 component; enhance styling for responsive design in JoinPage

feat(join): remove coloros from media queryies

feat(join): enhance password requirements display by refactoring to PasswordRequirements component

Enhance JoinPage with step titles and descriptions, refactor button layout

- Updated JoinForm to display step titles and descriptions using translation.
- Introduced ButtonContainer for consistent button layout across steps.
- Refactored Step1, Step2, and Step3 to utilize ButtonContainer for navigation buttons.
- Improved styling and structure of JoinPage for better alignment and spacing.
- Added styled components for better maintainability and readability.

Refactor useJoinSubmit: Migrate from .ts to .tsX, enhance error handling, and add user login functionality after form submission

defdf

refactor(join): streamline JoinPage components, enhance accessibility, and update translations

refactor(join): update JoinForm and step components to use fragments and improve data attributes for better accessibility

fix(useJoinSubmit): correct nonce handling and enhance logging for better debugging

fix(useJoinSubmit): correct nonce handling in login function

feat(join): reintroduce useJoinSubmit with enhanced error handling and user login functionality

fix(useJoinSubmit): replace navigate with document.location.href for redirection

fix(useJoinSubmit): remove unused navigate import and update redirect parameter name

fix(Step1): add early return in validateEmail for invited users

fix(useJoinSubmit): remove debug console logs from onSubmit function

feat(join): add loading and error states to JoinPage with corresponding components

feat: add WaitModal component for signup process indication

fix(JoinPage): center text in step title and update image imports for consistency

Refactor code structure for improved readability and maintainability

fix(PasswordRequirements): ensure text is bold for password requirement indicators

feat: Add animated image transitions to JoinPage and update background images

- Introduced ImagesColumn component to handle image transitions based on the current step in the join process.
- Updated JoinForm to remove step 1 description and adjusted layout to accommodate new ImagesColumn.
- Modified JoinPage to implement dynamic background images based on the current step.
- Added new images in webp format for better performance.
- Updated e2e tests to reflect changes in the JoinPage behavior and workspace input state.
- Updated yarn.lock to include new dependencies for motion animations.

fix(ImagesColumn): optimize animation calculations and clean up imports

Refactor code structure for improved readability and maintainability

fix(JoinForm): remove unused imports for cleaner code

fix(Join): correct file path casing for user project ID response

fix(LoginPage): remove password length validation for improved user experience

feat(JoinPage): integrate GTM event tracking for sign-up flow actions

fix(JoinPageError): update invitation status check to use URL parameters

fix(CampaignWidgets): correctly show to go plan link and improve layout and spacing

chore(DeleteProjectModal): remove unused imports

fix(GoogleTagManager): update tester_id to use profile_id from userData

fix(TemplateCardsGrid): ensure UserTag only displays valid output

feat(TaskTypeTitle): add styled component for task type title

style(TasksModal): improve layout and spacing in task modal

style(ButtonsContainer): adjust gap and padding for improved layout

refactor(TasksModal): replace SM component with TaskTypeTitle for consistency

Update src/pages/Plan/modules/Tasks/parts/modal/AccessibilityTasks.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

style(ButtonsContainer): adjust padding for consistent layout

refactor(TasksModal): remove unnecessary spaces

style(ButtonsContainer): simplify padding declaration for clarity

added translations and automatic yarn translate clean-up

fix(plan-save-draft): improve save configuration with success and error notifications

refactor: remove sensitive data and enhance event tracking in sign-up flow components

chore update api
…ition

UN-1400: fix error position and styling
…tags

UN-1415: include 'Insights' in invalidateTags on error handling
@d-beezee d-beezee merged commit 2744e60 into master Jun 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants