Conversation
…agement - Added role attributes to various components for improved accessibility. - Updated SendRequestModal to include error message title and role. - Enhanced TaskItem and TasksList with appropriate roles for better screen reader support. - Implemented role attributes in DeleteTaskConfirmationModal and TasksModal for consistency. - Refactored tests to utilize new RequestQuotationModal and TasksModule classes for better structure and maintainability. - Removed deprecated PlanPage class and integrated its functionality into the new structure. - Improved error handling in tests related to task management and request quotations.
… structure and maintainability - Updated language.spec.ts to utilize LanguageModule for language-related tests. - Refactored out_of_scope.spec.ts to use OutOfScopeModule for out of scope tests. - Modified target_size.spec.ts to implement TargetModule for target size tests. - Adjusted tasks.spec.ts to utilize Module_tasks for task-related tests. - Enhanced pending_review.spec.ts to incorporate various module classes for better organization. - Added RequestQuotationModal functionality for handling date inputs and validation. - Created new module classes for digital literacy, goal, language, out of scope, target, and tasks. - Removed deprecated methods from PlanPage and moved logic to respective module classes. - Introduced a new approved.spec.ts to test the approved state of a plan. - Added date.spec.ts to validate date input functionality in the request quotation modal. - Created a mock approved plan JSON for testing purposes.
UN-1343-accordion
… draft status and refactor tests for improved readability
…lity; enhance parallel job execution in workflow
… for bug uniqueness
- Implemented `deleteProjectsByPid` mutation in the API to handle project deletion. - Updated `apiTags` to invalidate relevant tags upon project deletion. - Added translations for delete project modal in English and Italian. - Created `DeleteProjectModal` component to confirm project deletion. - Integrated delete functionality into the project page header, allowing users to delete projects when no campaigns or plans are associated.
…ize unique bug logic
…ds into CampaignOverview
…d update related components
…dditional/useMaxItems.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s widgets for trend visualization
UN-1264: Fix plans view more behaviour
…r; update response types to include additional fields and new accessibility task type
UN-1383 fix: Move BugDetails component to correct position in BugPreview and Content
…r extraction and adjust styled component prop
UN-1342 feat: Refactor user state access and add Navigation component with header
feat: Add data-qa attribute to invite users button and update visibility tests
UN-1186 Enhance E2E tests + bugfix
UN-1325 refactor previous tests
…sage for improved clarity
Fix delete project
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR, titled "Release 20250519", introduces several refactorings and enhancements across the application. Key changes include:
- Reordering and deduplication of component renderings in Bug preview components.
- Updates to Italian and English translation files with new keys and messages.
- Refactorings in hooks (useGTMevent, useFeatureFlag, useActiveWorkspace, etc.) to use shallowEqual and improve state selection.
- API revisions including the removal of the sentiment endpoint and the addition of a DELETE project mutation, along with updates in schema definitions.
- UI improvements in inviteUsers components, transitioning from legacy StyledAccordion to the new AccordionNew, and dependency updates as well as CI workflow enhancements.
Reviewed Changes
Copilot reviewed 106 out of 106 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Bugs/Content/BugPreview.tsx | Reorders import and component usage; removes duplicate rendering |
| src/pages/Bug/Content.tsx | Adjusts order of attachment rendering |
| src/locales/{it,en}/translation.json | Updates translation keys and messages with new values |
| src/hooks/* | Refactors hooks to use shallowEqual and updates active workspace handling |
| src/features/navigation/* | Introduces new navigation components with streamlined logic |
| src/features/api/* | Adds DELETE project mutation and removes unused sentiment mutation endpoint |
| src/common/components/inviteUsers/* | Migrates from StyledAccordion to AccordionNew for improved UI in project/campaign settings |
| package.json & .github/workflows/e2e.yml | Bumps dependency versions and updates test shard configuration |
Comments suppressed due to low confidence (2)
src/features/api/index.ts:438
- Ensure that the new DELETE endpoint for projects is secured by proper authentication and authorization checks on the client side.
deleteProjectsByPid: build.mutation<DeleteProjectsByPidApiResponse, DeleteProjectsByPidApiArg>({
src/common/components/inviteUsers/projectSettings.tsx:334
- [nitpick] Verify that the new AccordionNew component maintains the intended UI and expand/collapse behavior consistent with the previous StyledAccordion implementation.
<AccordionNew isCompact level={3} key="workspace_users_accordion" defaultExpandedSections={[]}>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.