Conversation
… TouchpointItemNav, and NavItem components
Fixes to aside nav
…titleFromModuleType utility
…and TargetNote components
fix: grid blowout problem, min col is now explicitly set to 0 instead of auto
…ynamic prop to navigation links in TaskItemNav and TouchpointItemNav components
… in Navigation component
fix: adjust padding for ModulesList and TasksList components for bett…
feat: wrap PlanBody component in LayoutWrapper for improved layout structure
…r-note fix: replace Card with ContainerCard in InstructionsNote, SetupNote, and TargetNote components
…click UN-1036: fix closed sidebar on "templates" click
UN-1048: update scroll spacer height calculation in ModulesList component
Remove 'templates' case from sidebar dispatch logic
fix: adjust padding and margin in various components for improved layout
UN-1047: add missing subtitles to aside navigation
fix: restore LayoutWrapper in Templates page for consistent layout structure
UN-1010: Add delete plan feature
UN-1240-add-sentiment-theme
UN-1244 UN-1234-add-sentiment-data
UN-1081: update text in Experiential, Functional, Survey tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR releases version 20250505 with dependency updates, refactoring, new feature integrations, and localization improvements. Key changes include:
- Refactoring the deletion button event handling across several modules by wrapping the handleDelete call within an inline arrow function that stops event propagation.
- Introducing a new reusable useCopy hook and updating related components to use this hook while removing deprecated implementations.
- Incorporating new MediaSentiment support within the Video type, conditional archive handling for projects, and various layout and styling enhancements.
Reviewed Changes
Copilot reviewed 75 out of 78 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Plan/modules/Browser.tsx | Updated the delete button to use an inline arrow function with e.stopPropagation(). |
| src/pages/Plan/modules/Age.tsx | Applied a similar deletion button update with inline arrow function and event stoppage. |
| src/pages/Plan/modules/AdditionalTarget.tsx | Updated deletion button event handling to prevent unwanted propagation. |
| src/pages/Plan/modals/DeletePlanModal.tsx | Added a modal for plan deletion with improved error handling and toast notifications. |
| src/pages/Plan/common/NavContainer.tsx | Adjusted styling by changing padding to margin-right for improved layout consistency. |
| src/pages/Plan/PlanBody.tsx | Wrapped Grid inside LayoutWrapper for enhanced layout structure. |
| src/pages/Plan/ModulesList.tsx | Modified spacing with a responsive spacer height using calc for dynamic layout value. |
| src/pages/Plan/Controls.tsx | Enhanced controls with a new delete modal using ButtonMenu and IconButton integration. |
| src/pages/Dashboard/project-items/index.tsx | Updated ProjectItems to support archive projects with conditional title and subtitle. |
| src/pages/Dashboard/Project.tsx | Added archive project checks to conditionally render components and update the page title. |
| src/pages/Bug/Header/ActionsMenu.tsx | Cleaned up duplicate imports and updated copy link usage to the new hook implementation. |
| src/hooks/useCopyLink.tsx | Reimplemented hook to utilize the new useCopy hook for clipboard functionality. |
| src/hooks/useCopy.tsx | Introduced a new hook for copying text to clipboard with toast notifications on success/error. |
| src/features/navigation/Navigation.tsx | Removed redundant sidebar handling for template-related navigation. |
| src/features/api/index.ts | Extended Video type by adding the new MediaSentiment type for sentiment analysis integration. |
| src/common/components/utils/useCopyLink.tsx | Removed deprecated implementation in favor of the new hook-based approach. |
| src/common/components/inviteUsers/modalFooter.tsx | Updated import order and switched copy link hook usage to align with the new implementation. |
Files not reviewed (3)
- package.json: Language not supported
- src/locales/en/translation.json: Language not supported
- src/locales/it/translation.json: Language not supported
UN-1260: Add plan cta mother dashboard
UN-626: adjust displayed bug count in SingleGroupAccordion
fix: Update Android app link description for clarity
…nd remove redundant paragraph
style(modal): Update DeletePlanModal header to use isDanger prop
refactor(notifications): Update notification outro text for clarity and remove redundant paragraph
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces several improvements including dependency updates, refactoring of hooks and components, and new features such as sentiment analysis for video media. Key changes include the refactoring of the copy link functionality, conditional rendering based on project archival state, and updates to UI components for layout and navigation.
Reviewed Changes
Copilot reviewed 80 out of 83 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Plan/PlanBody.tsx | Wrapped plan content in a LayoutWrapper and updated StickyCol styling |
| src/pages/Plan/ModulesList.tsx | Adjusted padding for module items and updated scroll spacer height |
| src/pages/Plan/Controls.tsx | Integrated delete modal support and added additional action buttons |
| src/pages/Dashboard/project-items/index.tsx | Updated ProjectItems to receive an isArchive prop for conditional rendering |
| src/pages/Dashboard/Project.tsx | Rendered different page titles and controlled launch campaign card display based on project archive state |
| src/pages/Campaign/useWidgets/Functional/widgets.tsx | Introduced localized plan URL navigation within a footer CTA container |
| src/pages/Campaign/ExternalLink.tsx | Removed extra margin for improved layout consistency |
| src/pages/Bugs/Content/BugsTable/components/SingleGroupAccordion.tsx | Adjusted bug count display dynamically by subtracting three from the total count |
| src/pages/Bug/Header/ActionsMenu.tsx | Re-ordered imports and updated useCopyLink hook import location |
| src/hooks/useLocalizeDashboardUrl.ts | Added a new getLocalizedPlanUrl utility for plan URL generation |
| src/hooks/useCopyLink.tsx & src/hooks/useCopy.tsx | Refactored copy link functionality using a new reusable hook |
| src/features/navigation/Navigation.tsx | Removed redundant sidebar state handling for template routes |
| src/features/api/index.ts | Added new MediaSentiment type to support video sentiment analysis |
| src/common/components/utils/useCopyLink.tsx | Removed deprecated copy link implementation |
| src/common/components/navigation/asideNav/index.tsx | Adjusted divider margins for consistent spacing |
| src/common/components/inviteUsers/modalFooter.tsx | Reorganized import order and updated copy hook reference |
Files not reviewed (3)
- package.json: Language not supported
- src/locales/en/translation.json: Language not supported
- src/locales/it/translation.json: Language not supported
| /> | ||
| {t('__BUGS_PAGE_TABLE_SEE_ALL', 'see all')} | ||
| {` (${item.bugs.length})`} | ||
| {` (${item.bugs.length - 3})`} |
There was a problem hiding this comment.
Subtracting a fixed value of 3 from item.bugs.length can produce a negative number when there are fewer than 3 bugs. Add a safeguard to ensure the displayed count does not become negative.
Suggested change
| {` (${item.bugs.length - 3})`} | |
| {` (${Math.max(0, item.bugs.length - 3)})`} |
Kariamos
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a variety of changes, including dependency updates, code refactoring, new feature additions, and localization updates. Below is a categorized summary of the most important changes:
Dependency Updates
@appquality/unguess-design-systemdependency from version4.0.35to4.0.36inpackage.jsonto incorporate the latest design system improvements.Code Refactoring and Enhancements
useCopyLinkby removing its implementation fromsrc/common/components/utils/useCopyLink.tsxand reimplementing it using a new reusableuseCopyhook insrc/hooks/useCopy.tsx. This improves code modularity and reusability. [1] [2] [3]templatescase in theNavigationcomponent to simplify logic.New Features
MediaSentimenttype and integrated it into theVideotype insrc/features/api/index.ts, enabling sentiment analysis support for video media. [1] [2]src/pages/Dashboard/Project.tsxto conditionally renderLaunchCampaignCardsand pass anisArchiveprop toProjectItems.Localization Updates
src/locales/en/translation.jsonandsrc/locales/it/translation.json. [1] [2] [3] [4]Code Cleanup
src/common/components/inviteUsers/modalFooter.tsxandsrc/pages/Bug/Header/ActionsMenu.tsx. [1] [2]