fix(OtherCosts): update supplier options to use supplier ID instead o…#217
Merged
fix(OtherCosts): update supplier options to use supplier ID instead o…#217
Conversation
iDome89
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way option values are generated for cost types and suppliers in the
OtherCostssection of the campaign quote page. Instead of using the array index as the value, the code now uses the uniqueidfrom each item, ensuring more robust and stable identifiers.Improvements to option value generation:
valueproperty in the options generated byuseCostTypesanduseSuppliersto useitem.idinstead of the array index, improving stability and preventing potential issues if the list order changes. [1] [2]useCostTypes, removed the fallback for the label and now always usesitem.nameas the label.