Add presign url get other costs#521
Merged
Kariamos merged 5 commits intoUN-2274-other-costsfrom Feb 4, 2026
Merged
Conversation
Tests difference:New Tests |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the API for campaign finance "other costs" by adding presigned S3 URLs to each attachment, improving secure access to files. It updates both the backend logic and the OpenAPI schema, and introduces comprehensive tests to ensure correct behavior.
API and Schema Enhancements:
presigned_urlproperty, allowing secure, time-limited access to S3 files. [1] [2] [3] [4]Backend Logic Improvements:
getPresignedUrlfunction now accepts a configurable expiration time (default 20 minutes), and is used to generate presigned URLs for each attachment with a 3-hour expiration in the route handler. [1] [2] [3]Testing Updates:
getPresignedUrlfunction for predictable results.presigned_urlin the response. [1] [2] [3] [4]getPresignedUrlis called with the correct parameters for each attachment and the intended expiration time.