Merged
Conversation
Tests difference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a required
costfield to the "other costs" API and ensures that several fields are now required in both the OpenAPI specification and the TypeScript types. It also updates the backend logic and tests to include and validate the newcostfield for each item.API and Schema Updates:
itemsa required property in the response schema for the relevant endpoint inopenapi.yml, and marked several fields (includingcost,cost_id,type,supplier,description,attachments) as required for each item. [1] [2]costfield as a required number property for each cost item in both the OpenAPI schema and the generated TypeScript types, and updated the response examples accordingly. [1] [2] [3]Backend and Type Updates:
OtherCosttype and the backend route handler to include and return the newcostfield for each cost item. [1] [2] [3]Test Updates:
costfield in all relevant assertions for returned cost items. [1] [2] [3] [4] [5]Other Schema Improvements:
nameandidas required for nestedtypeandsupplierobjects, and madeid,url, andmimetyperequired forattachments. [1] [2] [3]