Skip to content

UN-2308 delete other cost #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iDome89 merged 5 commits into from
Feb 2, 2026
Merged

UN-2308 delete other cost #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4eca463
Modified src/reference/openapi.yml
Feb 2, 2026
b396767
feat: add DELETE endpoint for campaign finance other costs
Kariamos Feb 2, 2026
b89e62c
feat: implement DELETE endpoint for campaign finance other costs
Kariamos Feb 2, 2026
86ca664
feat: implement S3 deletion for campaign finance other costs
Kariamos Feb 2, 2026
cfa9e02
fix: ensure attachments are deleted from the database after S3 deletion
Kariamos Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions src/reference/openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13446,6 +13446,11 @@ paths:
- JWT: []
'/campaigns/{campaign}/finance/otherCosts':
parameters:
- schema:
type: string
name: campaign
in: path
required: true
Comment on lines +13449 to +13453
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The campaign parameter is defined twice - once inline and once through a reference. This creates a duplicate parameter definition. Remove the inline parameter definition (lines 13449-13453) and keep only the reference on line 13454, or vice versa, but not both.

Suggested change
- schema:
type: string
name: campaign
in: path
required: true

Copilot uses AI. Check for mistakes.
- $ref: '#/components/parameters/campaign'
get:
summary: Your GET endpoint
Expand Down Expand Up @@ -13624,6 +13629,41 @@ paths:
mime_type: image/jpeg
security:
- JWT: []
delete:
summary: Your DELETE endpoint
tags: []
responses:
'200':
description: OK
'400':
description: Bad Request
'403':
$ref: '#/components/responses/NotAuthorized'
'404':
$ref: '#/components/responses/NotFound'
'500':
description: Internal Server Error
operationId: delete-campaigns-campaign-finance-otherCosts
x-stoplight:
id: p9q4g69c20okp
security:
- JWT: []
requestBody:
content:
application/json:
schema:
type: object
required:
- cost_id
properties:
cost_id:
type: integer
x-stoplight:
id: b27nhd7f5ugfs
examples:
Example 1:
value:
cost_id: 80
servers:
- url: 'https://api.app-quality.com'
tags:
Expand Down
Loading
Loading