Merged
Conversation
… other costs endpoint
…and update schema
Tests difference:New Tests |
…ge.json and package-lock.json
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new endpoint for retrieving "other costs" associated with a campaign, refines the supplier endpoints to include supplier IDs, and updates the OpenAPI specification and tests to reflect these changes. The most significant updates are the addition of the
/campaigns/{campaign}/finance/otherCostsGET endpoint, improvements in supplier data handling, and enhanced OpenAPI documentation.New "Other Costs" Endpoint:
GET /campaigns/{campaign}/finance/otherCostsendpoint, including its implementation (_get/index.ts) and a comprehensive test suite. This endpoint returns detailed information about other costs for a campaign, including type, supplier, description, and attachments. [1] [2] [3]Supplier Endpoint Improvements:
idproperty in supplier objects, ensuring supplier IDs are returned in API responses and are properly tested. [1] [2] [3] [4]OpenAPI Specification Updates:
idproperty for suppliers and other cost types, and updated example responses accordingly. [1] [2] [3]supplier_idin the response and adjusted related tests. [1] [2] [3] [4]These changes collectively improve the API's consistency, add new functionality for financial data retrieval, and ensure that both documentation and tests accurately reflect the updated behavior.