Skip to content

Optional use own rounded BarRenderer 4.x#603

Closed
hannesa2 wants to merge 6 commits into
masterfrom
UseRoundedRenderer
Closed

Optional use own rounded BarRenderer 4.x#603
hannesa2 wants to merge 6 commits into
masterfrom
UseRoundedRenderer

Conversation

@hannesa2

@hannesa2 hannesa2 commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@hannesa2 hannesa2 changed the title Optional use rounded BarRenderer Optional use own rounded BarRenderer Dec 28, 2025
@hannesa2 hannesa2 changed the title Optional use own rounded BarRenderer Optional use own rounded BarRenderer 4 Dec 28, 2025
@hannesa2 hannesa2 changed the title Optional use own rounded BarRenderer 4 Optional use own rounded BarRenderer 4.x Dec 28, 2025
@hannesa2 hannesa2 force-pushed the UseRoundedRenderer branch 2 times, most recently from 191bea6 to d205e8e Compare December 28, 2025 12:49
@hannesa2

hannesa2 commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator Author

Screenshot differs: emulatorApi=9 with 21 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-11ToggleFilled.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-12ToggleCircles.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-40-LineChartTimeActivity-Hourly-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-7-PerformanceLineChart-Performance-1SampleClick.pngscreenshot

hannesa2
hannesa2 commented Dec 28, 2025
View reviewed changes
Comment thread chartLib/src/main/kotlin/info/appdev/charting/renderer/RoundedBarChartRenderer.kt
@@ -31,7 +31,8 @@ class RoundedBarChartRenderer(
barBorderPaint.strokeWidth = dataSet.barBorderWidth.convertDpToPixel()
shadowPaint.color = dataSet.barShadowColor

if (dataProvider.isDrawBarShadowEnabled) {
// if (dataProvider.isDrawBarShadowEnabled) {
if (true) {

@hannesa2 hannesa2 Dec 28, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only enabled the rendering @Paget96

@hannesa2

hannesa2 commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator Author

@Paget96
The thing is, that it wasn't used any where, so I add a usage for this RoundedBarChartRenderer.kt
I rebased on master, and now I can compare it with screenshots, but the result doesn't convince me.
I made the same on version 3.x as well, but there is the same poor outcome.

@hannesa2

hannesa2 commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator Author

Screenshot differs: emulatorApi=9 with 16 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-11-BarRoundedChartActivity-Basicwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-1SampleClick.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-10ToggleBarBorders.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-1ToggleValues.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-24rotateXAxislabels.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-4ToggleIcons.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-5ToggleHighlight.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-6TogglePinchZoom.pngscreenshot

StartTest_smokeTestStart-15-HorizontalBarRoundedChartActivity-Horizontalwithownroundedrenderer-2menu-click-7ToggleAutoScale.pngscreenshot

@hannesa2 hannesa2 force-pushed the master branch 4 times, most recently from 159d22d to 7dc3b14 Compare December 29, 2025 12:14
@hannesa2 hannesa2 force-pushed the master branch 4 times, most recently from f58a053 to 38179bc Compare January 2, 2026 09:53
@hannesa2
Optional use rounded BarRenderer
f45bf66
@hannesa2
Add rounded sample, currently with normal renderer
5a829eb
@hannesa2
Adapt new screenshots
063d56a
@hannesa2
Now with own rounded renderer
3d22e17
@hannesa2
Attempt to fix renderer
f761b86
@hannesa2
Update RoundedBarChartRenderer
079c594 
Added: Auto Full Radius Mode
Introduced a new setUseAutoFullRadius(true) function that enables automatic calculation of full corner radius for bars.

When enabled, the radius dynamically adapts based on the bar’s current screen width and height, ensuring fully rounded corners regardless of zoom level or chart scale.

This feature improves visual consistency, especially when zooming in/out, as the rounding remains proportional to each bar’s dimensions.

Fixed: Marker Not Showing on Highlight
Previously, markers were not appearing when bars were highlighted due to missing positional metadata.

This has been resolved by ensuring setHighlightDrawPos(...) is called inside drawHighlighted(), which correctly updates the Highlight object with the marker's draw position.

Now, the custom and other markers will be properly displayed above highlighted bars, even when using this renderer.
@hannesa2 hannesa2 force-pushed the UseRoundedRenderer branch from 0c27558 to 079c594 Compare January 2, 2026 10:15
@hannesa2 hannesa2 force-pushed the master branch 2 times, most recently from cf829c3 to 7776519 Compare January 18, 2026 07:28
@hannesa2

hannesa2 commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator Author

It doesn't work.
I'm at least be done here

@hannesa2 hannesa2 closed this Jan 19, 2026
@hannesa2 hannesa2 deleted the UseRoundedRenderer branch January 19, 2026 09:23
This was referenced Jan 19, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hannesa2