Skip to content

Gradient fix#600

Merged
hannesa2 merged 2 commits into
masterfrom
GradientFix
Dec 27, 2025
Merged

Gradient fix#600
hannesa2 merged 2 commits into
masterfrom
GradientFix

Conversation

@hannesa2

@hannesa2 hannesa2 commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator


generateFilledPath(dataSet, startIndex, endIndex, filled)

generateFilledPath(dataSet, currentStartIndex, currentEndIndex, filled)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turtleandr

I guess this is your suggested change. Let's see if screenshot diff shows the desired result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannesa2 yes, exactly

@hannesa2

Copy link
Copy Markdown
Collaborator Author

Screenshot differs: emulatorApi=9 with 1 screenshot(s)

setpoint|diff|actual screenshot

StartTest_smokeTestStart-42-GradientActivity-Gradient-1SampleClick.pngscreenshot

@hannesa2

hannesa2 commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator Author

Looks good !
The screenshot diff logic detected the improvement, and all other screenshots are still looking good
screenshot

@hannesa2 hannesa2 merged commit 9a11390 into master Dec 27, 2025
2 checks passed
@hannesa2 hannesa2 deleted the GradientFix branch December 27, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradient / alpha fill produces vertical stripes in LineChart

2 participants