Skip to content

Remove unneded variance #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannesa2 merged 2 commits into from
Dec 24, 2025
Merged

Remove unneded variance #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556d2b3
Cosmetic
hannesa2 Dec 24, 2025
f6e4976
Remove unneded variance
hannesa2 Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions MPChartLib/src/main/java/com/github/mikephil/charting/listener/BarLineChartTouchListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ import kotlin.math.sqrt
*/
@Suppress("MemberVisibilityCanBePrivate")
class BarLineChartTouchListener(
chart: BarLineChartBase<out BarLineScatterCandleBubbleData<out IBarLineScatterCandleBubbleDataSet<out Entry>>>,
chart: BarLineChartBase<out BarLineScatterCandleBubbleData<IBarLineScatterCandleBubbleDataSet<out Entry>>>,
touchMatrix: Matrix,
dragTriggerDistance: Float
) :
ChartTouchListener<BarLineChartBase<out BarLineScatterCandleBubbleData<out IBarLineScatterCandleBubbleDataSet<out Entry>>>>(chart) {
ChartTouchListener<BarLineChartBase<out BarLineScatterCandleBubbleData<IBarLineScatterCandleBubbleDataSet<out Entry>>>>(chart) {
/**
* the original touch-matrix from the chart
*/
Expand Down Expand Up @@ -501,10 +501,8 @@ class BarLineChartTouchListener(

chart.zoom(scaleX, scaleY, trans.x, trans.y)

if (chart.isLogEnabled) Log.i(
"BarlineChartTouch", ("Double-Tap, Zooming In, x: " + trans.x + ", y: "
+ trans.y)
)
if (chart.isLogEnabled)
Log.i("BarlineChartTouch", "Double-Tap, Zooming In, x: ${trans.x} y: ${trans.y}")

onChartGestureListener?.onChartScale(e, scaleX, scaleY)

Expand Down
2 changes: 1 addition & 1 deletion MPChartLib/src/main/java/com/github/mikephil/charting/listener/OnDrawListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ interface OnDrawListener {
fun onEntryAdded(entry: Entry)

/**
* Called whenever an entry is moved by the user after beeing highlighted
* Called whenever an entry is moved by the user after being highlighted
*/
fun onEntryMoved(entry: Entry)

Expand Down
3 changes: 1 addition & 2 deletions MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,7 @@ open class BarChartRenderer(
}

if (!isSingleColor) {
// Set the color for the currently drawn value. If the index
// is out of bounds, reuse colors.
// Set the color for the currently drawn value. If the index is out of bounds, reuse colors.
paintRender.color = dataSet.getColorByIndex(pos)
}

Expand Down
3 changes: 1 addition & 2 deletions MPChartLib/src/main/java/com/github/mikephil/charting/renderer/LineChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,7 @@ open class LineChartRenderer(

if (!viewPortHandler.isInBoundsRight(firstCoordinateX)) break

// make sure the lines don't do shitty things outside
// bounds
// make sure the lines don't do shitty things outside bounds
if (!viewPortHandler.isInBoundsLeft(lastCoordinateX) || !viewPortHandler.isInBoundsTop(
max(
firstCoordinateY.toDouble(),
Expand Down
Loading