Skip to content

barBuffers as MuteableList #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannesa2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

barBuffers as MuteableList #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0079cb
AbstractBuffer buffer as MutableList
hannesa2 Apr 10, 2025
eceb867
Buffer size
hannesa2 Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MPChartLib/src/main/java/com/github/mikephil/charting/buffer/AbstractBuffer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ abstract class AbstractBuffer<T>(size: Int) {

/** float-buffer that holds the data points to draw, order: x,y,x,y,... */
@JvmField
val buffer: FloatArray
var buffer: MutableList<Float> = mutableListOf()

/** animation phase x-axis */
@JvmField
Expand All @@ -30,7 +30,7 @@ abstract class AbstractBuffer<T>(size: Int) {

init {
index = 0
buffer = FloatArray(size)
buffer = FloatArray(size).toMutableList()
}

/** limits the drawing on the x-axis */
Expand Down
2 changes: 1 addition & 1 deletion MPChartLib/src/main/java/com/github/mikephil/charting/buffer/BarBuffer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ open class BarBuffer(size: Int, dataSetCount: Int, containsStacks: Boolean) : Ab
", containsStacks=" + containsStacks +
", inverted=" + inverted +
", barWidth=" + barWidth +
", buffer=" + buffer.contentToString() +
", buffer=" + buffer +
", index=" + index +
'}'
}
Expand Down
8 changes: 4 additions & 4 deletions MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ open class BarChartRenderer(
val barData = chart.barData
barBuffers = mutableListOf()

barData.dataSets.forEach {
barData.dataSets.forEach { iBarDataSet ->
barBuffers.add(
BarBuffer(
it.entryCount * 4 * (if (it.isStacked) it.stackSize else 1),
barData.dataSetCount, it.isStacked
iBarDataSet.entryCount * 4 * (if (iBarDataSet.isStacked) iBarDataSet.stackSize else 1),
barData.dataSetCount, iBarDataSet.isStacked
)
)
}
Expand Down Expand Up @@ -163,7 +163,7 @@ open class BarChartRenderer(
setBarWidth(chart.barData.barWidth)
feed(dataSet)
}
trans!!.pointValuesToPixel(buffer.buffer)
trans!!.pointValuesToPixel(buffer.buffer.toFloatArray())

val isCustomFill = dataSet.fills != null && dataSet.fills.isNotEmpty()
val isSingleColor = dataSet.colors.size == 1
Expand Down
4 changes: 2 additions & 2 deletions MPChartLib/src/main/java/com/github/mikephil/charting/renderer/HorizontalBarChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ open class HorizontalBarChartRenderer(

buffer.feed(dataSet)

trans!!.pointValuesToPixel(buffer.buffer)
trans!!.pointValuesToPixel(buffer.buffer.toFloatArray())

val isCustomFill = dataSet.fills != null && dataSet.fills.isNotEmpty()
val isCustomFill = dataSet.fills != null && !dataSet.fills.isEmpty()
val isSingleColor = dataSet.colors.size == 1
val isInverted = chart.isInverted(dataSet.axisDependency)

Expand Down
4 changes: 2 additions & 2 deletions MPChartLib/src/main/java/com/github/mikephil/charting/renderer/RoundedBarChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@ class RoundedBarChartRenderer(chart: BarDataProvider, animator: ChartAnimator, v
}
}

val buffer = barBuffers!![index]!!
val buffer = barBuffers[index]!!
buffer.setPhases(phaseX, phaseY)
buffer.setDataSet(index)
buffer.setInverted(chart.isInverted(dataSet.axisDependency))
buffer.setBarWidth(chart.barData.barWidth)
buffer.feed(dataSet)
trans!!.pointValuesToPixel(buffer.buffer)
trans!!.pointValuesToPixel(buffer.buffer.toFloatArray())

// if multiple colors has been assigned to Bar Chart
if (dataSet.colors.size > 1) {
Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/com/github/mikephil/charting/renderer/RoundedHorizontalBarChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class RoundedHorizontalBarChartRenderer(chart: BarDataProvider, animator: ChartA
buffer.setInverted(chart.isInverted(dataSet.axisDependency))
buffer.setBarWidth(chart.barData.barWidth)
buffer.feed(dataSet)
trans!!.pointValuesToPixel(buffer.buffer)
trans!!.pointValuesToPixel(buffer.buffer.toFloatArray())

// if multiple colors has been assigned to Bar Chart
if (dataSet.colors.size > 1) {
Expand Down
Loading