fix: adds key attribute to help react find dom changes on generated div#1
Open
DeveloperMetal wants to merge 1 commit intoAnurag810:mainfrom
Open
fix: adds key attribute to help react find dom changes on generated div#1DeveloperMetal wants to merge 1 commit intoAnurag810:mainfrom
DeveloperMetal wants to merge 1 commit intoAnurag810:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you create elements in a loop like the
users.map(...)in your code you need to tell react how to target these divs when an update happens.React doesn't know how or which of these generated divs should be updated if the
usersstate changes. So to help it you need to include thekeyattribute and pass it a unique id. It can be anything, but must be unique to this loop.See here for more info: https://reactjs.org/docs/lists-and-keys.html