Relecture réserve: Optimisation / reserve sts#3437
Merged
sylvmara merged 4 commits intofeature/reserve_model_lot3_scalianfrom Mar 19, 2026
Merged
Relecture réserve: Optimisation / reserve sts#3437sylvmara merged 4 commits intofeature/reserve_model_lot3_scalianfrom
sylvmara merged 4 commits intofeature/reserve_model_lot3_scalianfrom
Conversation
|
This PR is too big. Please break it up into smaller PRs. |
JasonMarechal25
commented
Feb 24, 2026
JasonMarechal25
changed the title
JasonMarechal25
changed the base branch from
develop
to
feature/reserve_model_lot3_scalian
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines short-term storage reserve participation constraints in the solver’s optimisation layer, mainly through a small runtime optimization (avoiding a copy) and several comment/documentation updates, plus removal of an obsolete down-reserve participation implementation.
Changes:
- Avoid copying
RESERVE_PARTICIPATION_STSTORAGEwhen building ST storage level reserve participation constraints. - Update/clarify comments around ST reserve participation and global energy level reserve participation formulas.
- Remove
STReserveDownParticipation.cppimplementation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/solver/optimisation/constraints/STStorageLevelReserveParticipation.cpp |
Uses a reference instead of copying reserve participation data while building constraints. |
src/solver/optimisation/constraints/STStorageGlobalEnergyLevelReserveParticipation.cpp |
Reworks documentation comments for global energy constraint formulation. |
src/solver/optimisation/constraints/STReserveParticipation.cpp |
Updates comments to reflect up/down reserve participation handling in one constraint. |
src/solver/optimisation/constraints/STReserveDownParticipation.cpp |
Removes the (apparently unused) down-participation constraint implementation file. |
src/solver/optimisation/constraints/STReleaseCapacityThresholds.cpp |
Updates comments for release capacity thresholds (introduces a typo). |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+11
to
19
| // Sum(P_{res,t_st} * R_{min,res} - J_up * R_{lambda,t_st}) <= n_min * R_up * - | ||
| // J_up | ||
| // | ||
| // Sum(P_{res,t_st} * R_{min,res} + J_down * R_{lambda,t_st}) <= n_min * R_up * | ||
| // J_down | ||
| // | ||
| // R_t : stock level at time t P_{res,t_st} : power participation for reserve down | ||
| // res at time t_st R_{min,res} : max power participation ratio R_up : max stock level | ||
|
|
Comment on lines
+33
to
34
| RESERVE_PARTICIPATION_STSTORAGE& reserveParticipations | ||
| = capacityReservation.AllSTStorageReservesParticipation[cluster]; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sylvmara
merged commit 09575e2
into
feature/reserve_model_lot3_scalian
4 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.