Skip to content

Optimization by daily chunk : remove [ANT-2695]#3044

Draft
guilpier-code wants to merge 9 commits intofeature/forbid-daily-simplexfrom
feature/remove-daily-simplex
Draft

Optimization by daily chunk : remove [ANT-2695]#3044
guilpier-code wants to merge 9 commits intofeature/forbid-daily-simplexfrom
feature/remove-daily-simplex

Conversation

@guilpier-code
Copy link
Copy Markdown
Contributor

@guilpier-code guilpier-code commented Sep 4, 2025

Fixes a part 2 of ticket ANT-2965 :
This PR follows PR 3048, and intends to :

  • make subsequent simplifications
  • remove dead code

What was done :

  • adapting / simplifying simulation table (modeler)
  • adapting / simplifying remix hydro
  • binding constraints removing automatic conversion of a weekly BC to daily BC
  • what else ?

@guilpier-code guilpier-code requested review from flomnes and payetvin and removed request for flomnes September 4, 2025 12:16
Comment on lines +440 to +441
//! Simplex optimization range (day/week)
SimplexOptimization simplexOptimizationRange;
SimplexOptimization simplexOptimizationRange = sorWeek;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! Simplex optimization range (day/week)
SimplexOptimization simplexOptimizationRange;
SimplexOptimization simplexOptimizationRange = sorWeek;
//! Simplex optimization range (day/week)
const SimplexOptimization simplexOptimizationRange = sorWeek;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Sep 5, 2025
@guilpier-code guilpier-code changed the base branch from develop to feature/forbid-daily-simplex September 5, 2025 09:45
@guilpier-code guilpier-code force-pushed the feature/remove-daily-simplex branch from 3d81d8c to 1e31f2c Compare September 5, 2025 10:56
@guilpier-code guilpier-code force-pushed the feature/remove-daily-simplex branch from 1e31f2c to de9fec1 Compare September 5, 2025 12:16
@flomnes flomnes changed the title Optimization by daily chunk : remove Optimization by daily chunk : remove [ANT-2695] Sep 5, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants