Feature/reserve model lot3 scalian by h-fournier · Pull Request #2575 · AntaresSimulatorTeam/Antares_Simulator

h-fournier · 2025-01-13T15:29:31Z

Add the reserves to the simulator.
Thermal clusters, Short term storage and Long Term storage can participate to the reserves

From @guilpier-code (reviewer) :
Have in mind that Antares Simulator is a legacy code.
It contains very poor historic code that we try to improve any time we can.
So Antares Simulator team can ask for better code quality where the surrounding code is poor.
You're not supposed to know that (something should have been done to inform Scalian sooner).

sonarqubecloud · 2025-04-04T09:44:32Z

Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 60%)
18.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud · 2025-05-19T10:55:28Z

Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 60%)
18.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

JasonMarechal25 · 2025-05-22T12:46:01Z

Hello. I've started to review this PR. I haven't read every thing yet.
My comment are often more on the "form" than the "matter".
One of the important point I would raise is the lack of unit testing.

Most of the comments are more on the "let's try to do it another way that I feel may be better" side rather than "I commend to do this". Feel free to challenge them or reach out directly for any question or discussion

guilpier-code · 2025-05-26T15:10:12Z

-	url = https://github.com/AntaresSimulatorTeam/Antares_Simulator_Tests_NR.git
-    branch = main
-    ignore = dirty
+	url = https://github.com/sylvmara/Antares_Simulator_Tests_NR.git


We should not forget to revert this file.

guilpier-code · 2025-05-27T08:15:22Z

Same as above : please revert this change on sub module.

sonarqubecloud · 2025-08-20T14:42:33Z

Quality Gate failed

Failed conditions
43.8% Coverage on New Code (required ≥ 60%)
18.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

flomnes

Utiliser Type* plutôt que std::optional<std::reference_wrapper<Type>>

…ourly results

pull-request-size · 2025-09-29T13:16:37Z

This PR is too big. Please break it up into smaller PRs.

…om/AntaresSimulatorTeam/Antares_Simulator into feature/reserve_model_lot3_scalian

flomnes

This PR is extremely large (15k+ lines of code) and has very few unit tests

…reserve_model_lot3_scalian

…e_model_lot3_scalian-sorties

- Fix issue on ReserveParticipation MARG.COST with the name - Fix issue with the ST group (duplicated groupName in the data structures) - Add columns to see EXP, std, min and max values for each output - Rework VCardReserveParticipationBase class with default values and add the possibility to output EXP, std, min, max or just EXP - Clean some functions related to the outputs

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merging after review

…reserve_model_lot3_scalian

Delete the derived() functions and change the functions to static functions

…om/AntaresSimulatorTeam/Antares_Simulator into feature/reserve_model_lot3_scalian

Solving issue [https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3546](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3546)

This reverts commit a8f251a.

[https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3549](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3549)

…del_lot3_scalian

Some modification after reading all modifications of the general PR of the reserves [https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/2575](https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/2575) Fixing some quick issues : - [https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3552](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3552) - [https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3554](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3554) --------- Co-authored-by: Florian Omnès <florian.omnes@rte-france.com>

sonarqubecloud · 2026-04-21T14:46:14Z

Quality Gate passed

Issues
937 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud

pull-request-size Bot added the size/XXL label Jan 13, 2025

JasonMarechal25 requested changes May 22, 2025

View reviewed changes

guilpier-code requested changes May 26, 2025

View reviewed changes

guilpier-code requested changes May 27, 2025

View reviewed changes

guilpier-code reviewed May 27, 2025

View reviewed changes

flomnes reviewed Sep 2, 2025

View reviewed changes

sylvmara added 5 commits September 11, 2025 10:06

Marginal cost for reserves is now an int

4d3eef4

Modification of parameters for reserves

5e2a7ee

Corrected bad optionnal access for thermal

6088694

Corrected bugs inside reserve outputs

ed81344

Merged with develop and inversion of indexes for short term storage h…

06c825f

…ourly results

sylvmara and others added 8 commits September 29, 2025 15:33

Formated using clang

339d5c9

Update windows-vcpkg.yml

6b219ea

Update ubuntu.yml

895e6b0

Corrected bad optionnal access bug

6372429

Merge branch 'feature/reserve_model_lot3_scalian' of https://github.c…

2cb19df

…om/AntaresSimulatorTeam/Antares_Simulator into feature/reserve_model_lot3_scalian

Modified structure of results

d6c3f2b

Float instead of int for most outputs

aad7e76

Avoiding zero division in symmetries

dd5988e

flomnes self-requested a review October 2, 2025 15:36

flomnes reviewed Oct 3, 2025

View reviewed changes

flomnes reviewed Oct 6, 2025

View reviewed changes

Comment thread src/solver/optimisation/ProblemMatrixEssential.cpp Outdated

sylvmara added 3 commits October 7, 2025 12:13

Resolved some problems for multiple areas with reserves

6a0dc74

Corrections to loadReserves and renamed cmake variable

ae517d2

Code quality updates

ed968eb

h-fournier and others added 20 commits January 20, 2026 15:10

Merge commit '609e642d75c2cbcdecbe13eb377129a1779ac605' into feature/…

2fa57b3

…reserve_model_lot3_scalian

Merge branch 'feature/reserve_model_lot3_scalian' into feature/reserv…

3e71daf

…e_model_lot3_scalian-sorties

Fix duplication

bb8f93e

Fix optionnal initialisation

b81bc62

Fix add GroupToResIndex

05e1de0

Try fix issue on CI

95a816d

Fix CI

b3bf3bb

[ANT-4172] Relecture réserves: sorties (#3287)

6a916d3

Change implementation to be supported by MSVC compiler

09da150

Comments fix and obsolete file deletion

ced14a8

Fix : Changed copy to reference

b8aad9e

Corrected comments on constraint 15 i

a8db3bf

Fix : comments

a58a445

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Relecture réserve: Optimisation / reserve sts (#3437)

09575e2

Merging after review

Merge commit 'e18ea60ce49e343e1ef91e05c2d442d313826be6' into feature/…

df31d47

…reserve_model_lot3_scalian

Feature/reserve fix derived (#3539)

33e0ecc

Delete the derived() functions and change the functions to static functions

Merge with develop

2d3db46

Merge branch 'feature/reserve_model_lot3_scalian' of https://github.c…

69c29b2

…om/AntaresSimulatorTeam/Antares_Simulator into feature/reserve_model_lot3_scalian

Fixed clang

d4ce331

h-fournier mentioned this pull request Apr 14, 2026

General review of the reserves PR #3566

Merged

h-fournier and others added 8 commits April 14, 2026 17:38

Delete the duplication in multiple classes

d8fa17f

Delete the duplication in multiple classes (#3569)

20a497f

Solving issue [https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3546](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3546)

Fix issue : #3549 and update corresponding tests

a8f251a

Revert "Fix issue : #3549 and update corresponding tests"

fe15af9

This reverts commit a8f251a.

Fix issue 3549 (#3574)

503c74e

[https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3549](https://github.com/AntaresSimulatorTeam/Antares_Simulator/issues/3549)

Merge remote-tracking branch 'origin/develop' into feature/reserve_mo…

8109d99

…del_lot3_scalian

Fix 1 error, 2 warnings

8659177

Conversation

h-fournier commented Jan 13, 2025 • edited by guilpier-code Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 4, 2025

Quality Gate failed

Uh oh!

sonarqubecloud Bot commented May 19, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JasonMarechal25 commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

guilpier-code May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guilpier-code May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 20, 2025

Quality Gate failed

Uh oh!

flomnes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-size Bot commented Sep 29, 2025

Uh oh!

flomnes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 21, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

h-fournier commented Jan 13, 2025 •

edited by guilpier-code

Loading

flomnes left a comment •

edited

Loading