feat(ui-reserves): add service layer methods and types#3217
Open
hdinia wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated “reserves” API service layer (schemas/types + CRUD functions) and wires it into TanStack React Query (keys, queries, mutations) so the UI can fetch/update reserve definitions and global parameters per study area.
Changes:
- Introduce Zod schemas and inferred TS types for reserve definitions and global parameters.
- Add API client methods for listing/getting/creating/updating/deleting reserves + get/update global parameters.
- Add React Query keys/queries/mutations for reserves data access.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webapp/src/services/api/studies/areas/reserves/types.ts | Adds inferred types and request parameter interfaces for reserves endpoints. |
| webapp/src/services/api/studies/areas/reserves/schemas.ts | Defines Zod schemas for reserves responses and request payload validation. |
| webapp/src/services/api/studies/areas/reserves/index.ts | Implements HTTP methods for reserves CRUD and global parameters endpoints. |
| webapp/src/queries/reserves/queries.ts | Adds React Query query options for reserves list/detail/global parameters. |
| webapp/src/queries/reserves/mutations.ts | Adds React Query mutation options for create/update/delete and global-parameters update. |
| webapp/src/queries/reserves/keys.ts | Introduces query/mutation key builders for reserves-related caching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skamril
requested changes
May 25, 2026
| return [...reserveKeys.list(studyId, areaId), "updateReserve"]; | ||
| }, | ||
| delete: (studyId: StudyMetadata["id"], areaId: AreaWithId["id"]) => { | ||
| return [...reserveKeys.list(studyId, areaId), "deleteReserves"]; |
Member
There was a problem hiding this comment.
"deleteReserve" without "s", or rename deleteMany
Member
Author
There was a problem hiding this comment.
the key is correctly named, it can delete one or more reserves. (not only multiple) singular "deleteReserve" is wrong too for the same reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.