feat(ui-studies): add active tree variant chip in breadcrumb navigation#3216
Open
hdinia wants to merge 2 commits into
Open
feat(ui-studies): add active tree variant chip in breadcrumb navigation#3216hdinia wants to merge 2 commits into
hdinia wants to merge 2 commits into
Conversation
skamril
requested changes
May 26, 2026
| const isLast = index === items.length - 1; | ||
| <Breadcrumbs maxItems={3} sx={separatorSx(activeTree)}> | ||
| <BreadcrumbRootChip | ||
| key={buildKey("__root__", 0)} |
Member
There was a problem hiding this comment.
key not necessary here (then + 1 for the key below too)
| component="span" | ||
| sx={{ | ||
| fontSize: "0.65rem", | ||
| fontWeight: 700, |
Member
There was a problem hiding this comment.
💡 I think it's better to used the predefined size:
<Typography fontSize="small" ...>
| @@ -0,0 +1,66 @@ | |||
| /** | |||
Member
There was a problem hiding this comment.
Can you add Utils at the end of the file?
|
|
||
| export type TreeVariant = "managed" | "external"; | ||
|
|
||
| export const variantColor = (variant: TreeVariant) => |
Member
There was a problem hiding this comment.
Mix of function declarations and arrow functions.
| > | ||
| {variantLabel(variant, t)} | ||
| </Typography> | ||
| <Box component="span" sx={{ width: "1px", height: 11, bgcolor: "divider", opacity: 0.7 }} /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.