refactor(dao): parametrize tests to run on FS and DB dao by smailio · Pull Request #3161 · AntaresSimulatorTeam/AntaREST

smailio · 2026-04-15T13:50:59Z

No description provided.

…-test

smailio · 2026-04-15T13:56:14Z


-        districts = dao.get_districts()
-        assert len(districts) == 2
+        districts = [d for d in dao.get_districts() if d.id != "all areas"]


fs dao fixture is initialized with all area, db dao fixture isn't.

Copilot

Pull request overview

This PR refactors multiple DAO/command tests so they can run against both filesystem (FS) and database (DB) StudyDao implementations, and aligns FS DAOs toward raising domain exceptions (notably AreaNotFound) to reduce backend-specific branching in tests.

Changes:

Parameterize several DAO test suites to run on both FS and DB backends (with DB-only sections kept for raw SQL assertions).
Align FS DAO behaviors/exceptions (renewables, thermals, links, xpansion) to raise more specific exceptions (e.g. AreaNotFound, CandidateNotFoundError, XpansionFileNotFoundError).
Update expected error messages in variant-study and integration tests to match AreaNotFound message format.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/variantstudy/model/command/test_update_renewable_cluster.py	Updates expected error message for missing area when updating renewables clusters.
tests/variantstudy/model/command/test_create_renewables_cluster.py	Updates expected error message for missing area when creating renewables clusters.
tests/study/dao/test_database_xpansion_dao.py	Generalizes xpansion DAO tests to `StudyDao` and adds backend-conditional assertions where behavior differs.
tests/study/dao/test_database_thermal_dao.py	Parameterizes thermal DAO tests across backends and separates DB-only cascade/SQL assertions.
tests/study/dao/test_database_scenario_builder_dao.py	Parameterizes scenario builder tests across backends and normalizes FS vs DB output differences.
tests/study/dao/test_database_renewable_dao.py	Parameterizes renewable DAO tests across backends and moves DB-only behavior to dedicated tests.
tests/study/dao/test_database_link_dao.py	Splits link DAO tests into shared vs DB-only (SQL inspection) sections and runs shared ones on both backends.
tests/study/dao/test_database_hydro_dao.py	Moves shared hydro tests to `StudyDao` and isolates DB-only behaviors (ValueError expectations, cascades, SQL checks).
tests/study/dao/test_database_district_dao.py	Parameterizes district DAO tests across FS/DB backends.
tests/integration/study_data_blueprint/test_renewable.py	Updates API error description assertions to match `AreaNotFound` message format.
antarest/study/storage/variantstudy/model/command/update_thermal_clusters.py	Switches to catching `AreaNotFound` when listing thermals per area.
antarest/study/storage/variantstudy/model/command/update_renewables_clusters.py	Switches to catching `AreaNotFound` when listing renewables per area.
antarest/study/dao/file/file_study_xpansion_dao.py	Improves FS xpansion exception semantics for missing candidates/config/files.
antarest/study/dao/file/file_study_thermal_dao.py	Maps FS tree missing-node errors to `AreaNotFound` and adds clearer exceptions on delete.
antarest/study/dao/file/file_study_renewable_dao.py	Adds `AreaNotFound` checks and improves delete/get behaviors for FS renewable DAO.
antarest/study/dao/file/file_study_link_dao.py	Improves FS link DAO exception types (`AreaNotFound`) and missing-node handling (`ChildNotFoundError`).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+# def test_get_renewable_matrix_raises_when_missing(dao: StudyDao) -> None:
+#     save_area(dao, "Paris")
+#     dao.save_renewable("paris", RenewableCluster(id="battery", name="Battery"))

-def test_get_renewable_matrix_raises_when_missing(db_dao: DatabaseStudyDao) -> None:
-    dao = db_dao
-    save_area(dao, "Paris")
-    dao.save_renewable("paris", RenewableCluster(id="battery", name="Battery"))
+#     with pytest.raises(RenewableClusterNotFound):
+#         dao.get_renewable_series("paris", "gas")
+#     with pytest.raises(AreaNotFound):
+#         dao.get_renewable_series("nonexistent", "gas")

-    with pytest.raises(RenewableClusterNotFound):
-        dao.get_renewable_series("paris", "gas")
-    with pytest.raises(AreaNotFound):
-        dao.get_renewable_series("nonexistent", "gas")

+# def test_save_renewable_matrix_raises_when_missing(dao: StudyDao) -> None:
+#     save_area(dao, "Paris")

-def test_save_renewable_matrix_raises_when_missing(db_dao: DatabaseStudyDao) -> None:
-    dao = db_dao
-    save_area(dao, "Paris")
-
-    with pytest.raises(RenewableClusterNotFound):
-        dao.save_renewable_series({"paris": {"gas": "missing-matrix-id"}})
-    with pytest.raises(AreaNotFound):
-        dao.save_renewable_series({"nonexistent": {"gas": "missing-matrix-id"}})
+#     with pytest.raises(RenewableClusterNotFound):
+#         dao.save_renewable_series({"paris": {"gas": "missing-matrix-id"}})
+#     with pytest.raises(AreaNotFound):
+#         dao.save_renewable_series({"nonexistent": {"gas": "missing-matrix-id"}})


smailio · 2026-04-15T14:47:34Z

+    names = {c.name for c in paris_clusters}
+    assert names == {"Battery", "Solar PaNELS"}
+    caps = {c.name: c.nominal_capacity for c in paris_clusters}
+    assert caps["Battery"] == 200.0
+    assert caps["Solar PaNELS"] == 500.0


Make test resilient if the FS and DB dao return identical result but with different order.

smailio · 2026-04-15T15:30:27Z

+    caps2 = {c.name: c.nominal_capacity for c in paris_clusters}
+    assert caps2["Battery"] == 1000.0
+    assert caps2["Solar PaNELS"] == 500.0
+    assert caps2["Wind"] == 100.0


also about order

…-test

smailio · 2026-04-22T20:35:32Z

        if file_study.config.version >= STUDY_VERSION_8_3:
            file_study.tree.save(
-                properties.adequacy_patch_properties.model_dump(mode="json", by_alias=True),
+                properties.adequacy_patch_properties.model_dump(mode="json", by_alias=True, exclude_none=True),


former code save None as a string like this

Well spotted, but seems to me that a None should not be considered a valid value for studies > 8.3
The "initialization" is supposed to fill it

smailio · 2026-04-22T20:43:36Z

+        trimming = ThematicTrimming()
+        initialize_thematic_trimming_against_version(trimming, self.get_impl().get_version())
+        return trimming.model_copy(update=row.thematic_trimming)


If we don't do this, version specific fields that weren't initialized during creation would return None instead of default value.

In practice this never happen as we always suply all fields, so this has no functional impact today.

However keeping both DAOs consistent prevents confusing discrepancies if either implementation is extended /used in a new module in the future

Indeed they will be supplied on creation anyway, I am not sure we should keep this code:
it does not incentivize us to have a clean creation in the first place, and it blurs the logic of this DAO where we want complete data in the first place.

smailio · 2026-04-22T20:44:46Z


        values = {"study_id": study_id, "layer_id": layer.id, "name": layer.name}
        upsert_one(session, LAYER_TABLE, values)
-        self.get_impl().save_layer_areas(layer.id, layer.areas)


In FS DAO we don't save areas

@override def save_layer(self, layer: Layer) -> None: file_study = self.get_file_study() file_study.tree.save(layer.name, ["layers", "layers", "layers", layer.id])

Here we need to fix the DAO signature to make things clear.
If this method is not supposed to update areas, it must have as an argument a class which does not hold the list of areas.
We should have a simpler class, like LayerMetadata or something like that.

Else we should refactor the callers so that they indeed use only one method to save both metadata and areas, but that would probably require more work

…-test

MartinBelthle

I read all the tests but not the source code. Really nice work

MartinBelthle · 2026-05-18T14:59:26Z

-                        )
+                        UserResourceDataCreation(path=rel_path, resource_type=ResourceType.FILE, blob_id=blob_id)
+                    )
+                elif item.is_dir():


As discussed, either we find a way to only return files and empty folders instead of rglob (not sure it exists), or we add a and not next(item.listdir())

MartinBelthle · 2026-05-18T15:25:28Z

+    Recursively remove keys whose value is an empty dict.
+
+    Normalizes FS vs DB scenario-builder output: the FS backend leaves empty
+    area dicts after all clusters are deleted, while the DB backend prunes


As discussed, we should have the same behvior for FS and DB meaning we should initialize missing data for the get_scenario_by_type method in the DB DAO

MartinBelthle · 2026-05-18T15:29:03Z

+            2: PlaylistValues(status=False),
+            3: PlaylistValues(status=False),
+            4: PlaylistValues(status=False, weight=0.2),
+            7: PlaylistValues(weight=1.1),


Makes me realize that it does not make sense to set a Playlist for year 7 when the study has only 4 years. We should probably validate this but won't be done inside this PR

MartinBelthle · 2026-05-18T15:30:05Z

-    stmt = select(COMMENTS_TABLE.c.comments).where(COMMENTS_TABLE.c.study_id == dao.get_study_id())
-    assert db_session.execute(stmt).scalar_one() == comments
+    if isinstance(dao, DatabaseStudyDao):
+        stmt = select(COMMENTS_TABLE.c.comments).where(COMMENTS_TABLE.c.study_id == dao.get_study_id())


Here you keep the part of the test where we check the DB content btut everywhere else seems you removed it. I think we can remove it from here too

MartinBelthle · 2026-05-18T15:31:37Z

-        assert db_session.execute(select(COST_VARIATION_INJECTION_TABLE)).fetchall() == []
-        assert db_session.execute(select(COST_VARIATION_WITHDRAWAL_TABLE)).fetchall() == []
+    if isinstance(dao, DatabaseStudyDao):
+        with db_session:


Same remark, I'm fine with keeping this but you removed such thigns from other tests so we should do the same thing everywhere

MartinBelthle · 2026-05-18T15:40:51Z

+) -> StudyDao:
+    if backend == "database":
+        dao = build_db_dao(db_session, matrix_service, STUDY_VERSION_9_3)
+        ConstantsMatrixUsageProvider(dao.generator_matrix_constants, matrix_service)


This should already be done inside the build_db_dao

MartinBelthle · 2026-05-18T15:43:35Z


-def test_provider_includes_reserve_need_matrix(db_session: Session, matrix_service: ISimpleMatrixService) -> None:
-    dao = build_db_dao(db_session, matrix_service, STUDY_VERSION_10_0)
+def test_provider_includes_reserve_need_matrix(dao_10_0: StudyDao, core_cache: ICache) -> None:


You can add a TODO inside this test saying that it'll be removed when we'll fully support the v10.0 as it will be integrated inside the test_garbage_collection one

MartinBelthle · 2026-05-18T15:46:42Z

        assert all_properties == {"paris": default_props, "london": default_props}

-    assert len(db_recorder.sql_statements) == 1, str(db_recorder)
+    assert len(db_recorder.sql_statements) == 2, str(db_recorder)


Specify that the 2nd query is to get the study version

MartinBelthle · 2026-05-18T15:47:43Z


    # Ensures we modified the properties accordingly
-    assert dao.get_area_properties(area_id) == new_properties
+    expected = new_properties.model_copy()


Not sure to understand why you need to copy. Couldn't you remove this line ?

MartinBelthle · 2026-05-18T15:49:42Z

-    assert dao.get_timeseries_config() == TimeSeriesConfiguration()
-    assert dao.get_thematic_trimming() == expected_thematic_trimming
+    actual_general = dao.get_general_config()
+    assert actual_general == expected_general_config, explain_model_diff(actual_general, expected_general_config)


Minor: I like explain_model_diff but to me it should be used ponctually and not in the tests hard-coded, it makes the test harder to read IMO

This reverts commit 1fdbdb3.

…-test

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated 6 comments.


-def test_thermal_matrices_lifecycle(db_session: Session, db_dao: DatabaseStudyDao) -> None:
-    dao = db_dao
+def test_thermal_matrix_round_trip(dao: StudyDao, matrix_service) -> None:


smailio · 2026-05-25T21:30:05Z

+            constraints_result: dict[str, Any] = {
+                area_id: {storage_id: {} for storage_id in storages}
+                for area_id, storages in self.get_impl().get_all_st_storages().items()
+            }
+            for area_id in self.get_impl().get_all_area_ids():
+                constraints_result.setdefault(area_id, {})


align DB with FS. Entires must be set for each constraint.

…-test

smailio · 2026-05-25T22:30:54Z

-        return self.get_impl().get_matrix(_get_load_matrix_path(area_id))
+        return self._get_area_matrix(area_id, _get_load_matrix_path)


I just make FS dao raise same error than DB dao

smailio · 2026-05-25T22:34:54Z

+        if renames:
+            self._apply_projection_renames(renames)


aligh FS with DB. Updates should cascade.

smailio · 2026-05-25T22:39:56Z

+        projection = settings.sensitivity_config.projection if settings.sensitivity_config else []
+        if projection:
+            existing_names = {c["name"] for c in self._get_all_xpansion_candidates().values()}
+            missing = [name for name in projection if name not in existing_names]
+            if missing:
+                raise CandidateNotFoundError("One or more candidates in the projection do not exist")


DB dao enforce it so FS should too. Plus this would make the DB dao look slower when it actually just does more work.

…ly, also revert formating

smailio · 2026-05-26T07:26:31Z

+revision = "4121d3b48393"
+down_revision = "rp986cf862cy"


when i merged dev my ruff wasn't happy with single quotes

smailio · 2026-05-26T07:28:49Z

+    if study_version >= STUDY_VERSION_8_4:
+        # FS gets this via the empty_study template's generaldata.ini; DB has no template.
+        optimization_preferences.transmission_capacities = TransmissionCapacities.LOCAL_VALUES


I can't put this in initialize_optimization_preferences_against_version because initialize_optimization_preferences_against_version is called each time we parse a file study, so on each read, and it would overwrite the default value (which is True and not None, so I can't just check is None, and I can't indentify an instance where transmission_capacities was set to True vs an instance where transmission_capacities was never updated).

Yes, as discussed it's the right place :)
It's the equivalent of having different values between version templates, on the FS side.

MartinBelthle · 2026-05-27T13:54:59Z

            table, id_col = _AREA_ITEM_TABLE_MAP[scenario_type]
            stmt = select(table).where(table.c.study_id == study_id)
-            result: dict[str, Any] = {}
+            result: dict[str, Any] = {area_id: {} for area_id in self.get_impl().get_all_area_ids()}


Why are you initializing for 2 if but not for the others ? Seems you should do it for all cases

MartinBelthle · 2026-05-27T13:58:50Z

+    else:
+        activated = sum(1 for v in playlist.years.values() if v.status)
+        default_status = activated > len(playlist.years) // 2
+    expanded = dict(playlist.years)


Minor but why are you using dict(...), playlist.years is already a dict

MartinBelthle · 2026-05-27T15:10:49Z

+        default_status = True
+    else:
+        activated = sum(1 for v in playlist.years.values() if v.status)
+        default_status = activated > len(playlist.years) // 2


Discussed the matter with Sylvain and we think you should always consider the default_status is True. It will be different from the FS but we'd actually want the FS to be like the DB for this case as it's less misleading.

You don't have to modify the FS Dao in this PR just consider the default_status to be True and we'll be good

MartinBelthle · 2026-05-27T15:18:34Z

    @override
    def get_reserves_global_parameters(self, area_id: str) -> ReservesGlobalParameters:
        file_study = self.get_file_study()
+        check_area_exists(file_study.config, area_id)


Makes me realize that you could use this in other DAOs you've modified to simplify a bit the reading

MartinBelthle · 2026-05-27T15:19:56Z

    @override
    def get_all_reserves_global_parameters(self) -> ReservesGlobalParametersMapping:
        file_study = self.get_file_study()
-        return {area_id: self.get_reserves_global_parameters(area_id) for area_id in file_study.config.areas}


Not sure to understand why you've changed this code. Was easier to read

MartinBelthle · 2026-05-27T15:25:24Z


        for area_id, value in data.items():
            for storage_id, constraints in value.items():
+                if not self.st_storage_exists(area_id, storage_id):


This is not performant at all. For the rest of the modification you've done I'm okay with them because they either use the config or they are in the deletion methods which are almost never used. But here I think we should be careful with performances.

We should also use the config here or at least check the file only once per area to avoid several I/O operations on the same file (.config is faster we should use it and even do it once per area to avoid going through the sts list several times)

MartinBelthle · 2026-05-27T15:28:32Z

+        # Mirror the DB read path which initializes version-specific defaults
+        # (enabled, ...) so consumers reading from `config` see the same
+        # fully-populated storage as the DB DAO returns.
+        initialize_st_storage(storage, study_data.version)


I think we don't need this, but I'll let Sylvain give his opinion

MartinBelthle · 2026-05-27T15:40:31Z

+        filters_synthesis = values.pop(
+            "filter-synthesis", values.pop("filter_synthesis", values.pop("filters_synthesis", ""))
+        )
+        filters_year = values.pop(
+            "filter-year-by-year", values.pop("filter_year_by_year", values.pop("filters_year", ""))
+        )


Not sure to understand why you changed this code

MartinBelthle · 2026-05-27T15:52:53Z

+        for area_id, ui_info in ui_info_map.items():
+            ui_data = AreaUIData.model_validate(AreaUIFileData(**ui_info).to_config())
+            if ui_data.layer_x:
+                ui_data.ui["layers"] = " ".join(sorted(ui_data.layer_x, key=int))


This does not seem to be what we're doing in DB, I'm confused and the Area ui code sucks so much.

In DB there's no notion of if layer_x

To me we shouldn't modify this code to make it even harder to understand for a case that never happens.

sylvlecl

A few comments, could't review everything yet

sylvlecl · 2026-05-27T13:01:48Z

+    initialize_area_properties(props, study_version)
+    return props


In reality, this should never be useful for database implementation: the "initialization" goal is to replace missing data with their default values, but in database impl we should never have a missing data: the default value data should always be inserted from the start.

So I would be more in favor of removing this. If it's needed, it means there's a problem upstream.

sylvlecl · 2026-05-27T13:16:42Z


        values = {"study_id": study_id, "layer_id": layer.id, "name": layer.name}
        upsert_one(session, LAYER_TABLE, values)
-        self.get_impl().save_layer_areas(layer.id, layer.areas)


Here we need to fix the DAO signature to make things clear.
If this method is not supposed to update areas, it must have as an argument a class which does not hold the list of areas.
We should have a simpler class, like LayerMetadata or something like that.

Else we should refactor the callers so that they indeed use only one method to save both metadata and areas, but that would probably require more work

sylvlecl · 2026-05-27T15:12:01Z

+    if study_version >= STUDY_VERSION_8_4:
+        # FS gets this via the empty_study template's generaldata.ini; DB has no template.
+        optimization_preferences.transmission_capacities = TransmissionCapacities.LOCAL_VALUES


Yes, as discussed it's the right place :)
It's the equivalent of having different values between version templates, on the FS side.

sylvlecl · 2026-05-27T15:15:42Z

+        trimming = ThematicTrimming()
+        initialize_thematic_trimming_against_version(trimming, self.get_impl().get_version())
+        return trimming.model_copy(update=row.thematic_trimming)


Indeed they will be supplied on creation anyway, I am not sure we should keep this code:
it does not incentivize us to have a clean creation in the first place, and it blurs the logic of this DAO where we want complete data in the first place.

sylvlecl · 2026-05-28T07:19:56Z

+        for area_id, ui_info in ui_info_map.items():
+            ui_data = AreaUIData.model_validate(AreaUIFileData(**ui_info).to_config())
+            if ui_data.layer_x:
+                ui_data.ui["layers"] = " ".join(sorted(ui_data.layer_x, key=int))


Hmmm, I mostly agree. Indeed we ensure stronger consistency in the DB implementation, with foreign keys, cascade deletes and so on, which is a good thing: we can never have data for a layer that does not exist.
But here, if files contain inconsistencies, I don't think we should try to hide them on the fly.

But let's not lose time on this, it's not important.
If we want to make this right, we'll need to dig a little more: for example it may make sense to have a layer absent from the list, but still have coordinates, because maybe the user wanted to mask it temporarily without losing the coordinates.
To be honest we don't care about that kid of details for now, it has not been well thought in the past, and we'll not do it now

sylvlecl

Mostly very good stuff bu I think there is a few places where the adaptation is not relevant.
In particular we need to have a clear idea of the rsponsibilities of the DAO layer vs higher layer, in particular for missing values and validation:

DAO layer should validate its inputs against study version
DB DAO should not bother filling missing values, because we forbid missing values
FS DAO must fill missing values, because it's part of the format definition

sylvlecl · 2026-05-28T07:34:00Z

    @override
    def delete_layer(self, layer_id: str) -> None:
+        if layer_id == DEFAULT_LAYER_ID:
+            raise LayerNotAllowedToBeDeleted()


sylvlecl · 2026-05-28T07:36:00Z

    def get_renewable_series(self, area_id: str, renewable_id: str) -> pl.DataFrame:
-        return self.get_impl().get_matrix(_get_renewable_series_path(area_id, renewable_id))
+        if area_id not in self.get_file_study().config.areas:
+            raise AreaNotFound(area_id)


Nice: seems like it's a very common check: maybe we should have a small function "check_area_exists" ?

Ah indeed there's already a comment about this

sylvlecl · 2026-05-28T07:38:45Z

            data = file_study.tree.get(_get_reserves_ini_path(area_id))
        except (ChildNotFoundError, KeyError):
            data = {}
+        if GLOBAL_PARAMETERS_SECTION not in data:


Don't we want to use the default values here instead ?

Elaborating on this:
having missing data in files is not the same as having missing data in DB.

having missing data in files must be interpreted, in general, as "use the default values". This is not our convention, this is the convention of the simulator, and we must stick with it. We don't have control on the files that we receive, so we cannot assume that everything is defined

having missing data in DB is an application error. We should assume that we don't have missing data in our DB, because WE filled it up in the first place.

So it's natural to have differences in that case:

for FS, we must fill missing values with default values

for DB, we should not do it: if there is missing data, it's an application error that we must fix in the code

sylvlecl · 2026-05-28T07:39:59Z

+                data = file_study.tree.get(_get_reserves_ini_path(area_id))
+            except (ChildNotFoundError, KeyError):
+                continue
+            if GLOBAL_PARAMETERS_SECTION not in data:


Same here, I think we want default values instead of removing the area from the map.

sylvlecl · 2026-05-28T08:01:13Z

+        # Mirror the DB read path which initializes version-specific defaults
+        # (enabled, ...) so consumers reading from `config` see the same
+        # fully-populated storage as the DB DAO returns.
+        initialize_st_storage(storage, study_data.version)


I think we should not do it:
what we should have is a content-check on the object which is received, which should alreay be a "full" object, otherwise we should raise.

In that particular case, I think the DB side is not right either:

on write it should perfom the content check

on read it should not try to fill missing data. Same pattern as other comments

sylvlecl · 2026-05-28T16:31:45Z

+        filters_synthesis = values.pop(
+            "filter-synthesis", values.pop("filter_synthesis", values.pop("filters_synthesis", ""))
+        )
+        filters_year = values.pop(
+            "filter-year-by-year", values.pop("filter_year_by_year", values.pop("filters_year", ""))
+        )


Seems to me the only 2 places we use that class are:

from the INI file (kebab case stuff):
for that we should just refactor _parse_links_filtering to use parse_link which already handles the parsing logic

from the Link class:
there we should refactor the to_config method to just pass explicitly arguments to the LinkConfig constructor

Then we can get rid of that obscure validator

smailio added 4 commits April 15, 2026 11:08

refactor(dao): align file DAO exceptions with DB DAO and share test

35a8f8b

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

ca0a7a5

…-test

fix tests

3ab15ad

fix test

b62fa75

pull-request-size Bot added the size/XXL label Apr 15, 2026

smailio requested a review from Copilot April 15, 2026 13:51

Copilot started reviewing on behalf of smailio April 15, 2026 13:51 View session

github-code-quality Bot found potential problems Apr 15, 2026

View reviewed changes

Comment thread tests/study/dao/test_database_renewable_dao.py Fixed

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

140065c

…-test

smailio commented Apr 15, 2026

View reviewed changes

Copilot AI reviewed Apr 15, 2026

View reviewed changes

smailio added 3 commits April 15, 2026 16:16

refactor test links dao

d28ba16

refactor test links dao

ea8dc1a

refactor test links dao

5a8f90f

smailio commented Apr 15, 2026

View reviewed changes

refactor test renewable dao

91332dc

smailio commented Apr 15, 2026

View reviewed changes

smailio added 8 commits April 17, 2026 15:34

wip

d5a913c

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

245e734

…-test

fix test and align exception

b634cef

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

ab54cbb

…-test

thematic trimming

ba8febb

layers

6a1f985

area properties

0edc5bc

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

fdaeb8a

…-test

smailio commented Apr 22, 2026

View reviewed changes

smailio added 2 commits April 23, 2026 10:51

settings

5062d2c

intialize study

211d10e

smailio added 3 commits May 13, 2026 11:50

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

d4d20d6

…-test

light refactor

92e411d

Merge branch 'dev' into refactor/add-multi-dao-test

3e3e46f

smailio requested a review from MartinBelthle May 18, 2026 11:31

MartinBelthle requested changes May 18, 2026

View reviewed changes

smailio added 5 commits May 19, 2026 16:40

light refactoring

1fdbdb3

Revert "light refactoring"

413b4f7

This reverts commit 1fdbdb3.

fix everything

306a467

fix test

091efef

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

90a4125

…-test

github-code-quality Bot found potential problems May 22, 2026

View reviewed changes

Comment thread tests/study/dao/test_garbage_collector.py Fixed

test(dao): align tests with dev signature and version changes

1e9c2c9

smailio requested a review from Copilot May 25, 2026 21:01

Copilot started reviewing on behalf of smailio May 25, 2026 21:01 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

smailio commented May 25, 2026

View reviewed changes

smailio added 3 commits May 25, 2026 23:57

Merge dev

157adf6

better comments

f54411c

Merge remote-tracking branch 'origin/dev' into refactor/add-multi-dao…

0ba31eb

…-test

smailio commented May 25, 2026

View reviewed changes

smailio requested a review from MartinBelthle May 26, 2026 07:22

revert(optimization): keep v8.4 transmission_capacities default DB-on…

7a97ebb

…ly, also revert formating

smailio commented May 26, 2026

View reviewed changes

MartinBelthle requested changes May 27, 2026

View reviewed changes

sylvlecl reviewed May 27, 2026

View reviewed changes

sylvlecl reviewed May 28, 2026

View reviewed changes

		return self.get_impl().get_matrix(_get_load_matrix_path(area_id))
		return self._get_area_matrix(area_id, _get_load_matrix_path)

		initialize_area_properties(props, study_version)
		return props

		revision = "4121d3b48393"
		down_revision = "rp986cf862cy"

Conversation

smailio commented Apr 15, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinBelthle left a comment

Choose a reason for hiding this comment

Uh oh!

MartinBelthle May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

MartinBelthle May 18, 2026 •

edited

Loading

MartinBelthle May 27, 2026 •

edited

Loading