Conversation
|
@algal looks like there's some minor changes still needed based on the description before this can be merged. |
|
@jph00 Yeah. I think this is still marked draft becaase it's not complete. It's not ready for review or merge. |
|
@algal would be nice to get this finished and merged - wdyt? |
|
On it! |
|
Working this on a new branch: https://github.com/AnswerDotAI/fastmigrate/tree/flatten-tests2 |
|
@pydanny Hey Danny! I'm not sure if you have time for this at the moment, but if you are curious to give it a look, I continued this work and replaced all uses of I assume you're probably busy with other things, but please let me know if you care to give it a review. :) |
While this looks like a HUGE change, in reality it is minimal. What it does:
tempfile.TemporaryDirectory()context processor with thetmp_pathpytest fixture, which provides a Path object instead of a stringNote
This will be pulled out of draft once the other tests are converted to use
tmp_path