add hazard pointers for safe memory reclamation#4
Open
AneesPatel wants to merge 1 commit into
Open
Conversation
Fixes the ABA / use-after-free problem in the Treiber stack. Threads publish what they're reading before dereferencing, scan on retire to only free things nobody is currently protecting. Simple version: one slot per thread, fixed max thread count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hazard pointer implementation for deferred memory reclamation. Fixes the use-after-free problem that's lurking in the Treiber stack (PR #1).
The problem
In a lock-free pop: thread A reads
head, gets preempted. Thread B pops the same node and deletes it. Thread A resumes and dereferences a freed pointer. Bad.The fix
Before dereferencing any pointer that might be concurrently freed, publish it in a per-thread hazard slot. When retiring a node, scan all published hazard pointers first - only free it if nobody has it published.
Notes
MAX_THREADS=16, one slot per thread (thread-local, acquired on first use).BATCH_SIZE=32retirements - not on every pop.SafeStackvariant, verifies correct pop count across 4 prod + 4 cons threads.Files
include/HazardPointers.htests/test_hazardpointers.cppCMakeLists.txt