Introduce MistralRequestCoordinator and queued auto-screenshot handling#72
Closed
Android-PowerUser wants to merge 4 commits intofix-compilation-errors-in-mainactivity.kt-h8jilxfrom
Conversation
Contributor
There was a problem hiding this comment.
Review Summary
The PR successfully introduces MistralRequestCoordinator to centralize Mistral API request coordination with adaptive retry logic and cooldown management. The queuing mechanism for auto-screenshot requests prevents excessive parallel requests. The implementation is clean and well-structured.
Key Changes:
- ✅ New
MistralRequestCoordinatorencapsulates cooldowns, retry logic, and header parsing - ✅ Replaced ad-hoc retry logic in both
ScreenCaptureApiClientsandPhotoReasoningViewModel - ✅ Added queuing for auto-screenshot-triggered Mistral requests with latest-wins strategy
- ✅ Proper integration with finally blocks for queue draining
The changes are well-implemented and ready for merge. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
network/MistralRequestCoordinator.ktthat encapsulates key cooldowns, adaptive retries, parsing ofRetry-Afterandx-ratelimit-resetheaders, and selection of API keys viaexecute(...)returningMistralCoordinatedResponse.ScreenCaptureApiClients.callMistralApito useMistralRequestCoordinator.execute(...)when executing HTTP calls.PhotoReasoningViewModel.reason(...)with a call toMistralRequestCoordinator.execute(...)and remove redundant key bookkeeping logic.PhotoReasoningViewModelby introducingQueuedMistralScreenshotRequest,enqueueMistralAutoScreenshotRequest,dispatchMistralAutoScreenshotRequest, andreleaseAndDrainMistralAutoScreenshotQueueto ensure only one in-flight Mistral auto-request and latest-wins queuing.Testing
./gradlew assembleDebugand./gradlew test, and the build and unit tests completed successfully.Codex Task