Added text of signs placed on all blocks that provide tabs to the tab tooltips#52
Draft
TheMrEngMan wants to merge 2 commits intoAndrew6rant:1.19.3from
Draft
Added text of signs placed on all blocks that provide tabs to the tab tooltips#52TheMrEngMan wants to merge 2 commits intoAndrew6rant:1.19.3from
TheMrEngMan wants to merge 2 commits intoAndrew6rant:1.19.3from
Conversation
… tooltips. The sign must be placed directly on the chest/barrel/shulker box etc. to show up in the tooltip. Text color applied with dyes and custom formatting is also applied to tooltip text. This works for double chests and chests identified with item frames as well.
Owner
|
This is fantastic, sorry for the delay in reviewing this PR, I've been very busy these past few weeks. I've noticed one small issue - the tooltip seems to snap strangely on double chests. Check it out: Single Chest: Minecraft_.1.19.-.Singleplayer.2022-09-04.15-22-02.mp4Double Chest: Minecraft_.1.19.-.Singleplayer.2022-09-04.15-22-22.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sign must be placed directly on the chest/barrel/shulker box etc. to show up in the tooltip.
Text color applied with dyes and custom formatting is also applied to tooltip text.
This works for double chests and chests identified with item frames as well.
Draft pull request because there is an overlap issue with the tooltips and status effects on the right of the inventory, simply changing the z-offset of the tooltips (by translating the MatrixStack in the z direction before drawing the tooltips) didn't seems to fix this issue...
