Added disable_when_fullscreen for hyprland#37
Added disable_when_fullscreen for hyprland#37indigo0445 wants to merge 1 commit intoAndreasBackx:mainfrom
Conversation
AndreasBackx
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Unfortunately, I'm not sure that calling hyprctl each time is a good idea. I feel like there should be a better way of doing this, via some Wayland API. If that exists, I might consider the implementation. I don't think doing this is a great solution.
If you want to unblock yourself, you could accomplish this by setting the command to something like hyprctl activewindow -j | SOME_JK_PIPING_MAGIC && $COMMAND.
Let me know if you know of such a Wayland API existing.
|
Yeah I'm not aware of a universal API for Wayland that can check for fullscreen... |
|
Maybe wlr-foreign-toplevel-management could be used, to get such information from the state events. It works on Hyprland, Sway and Niri; other popular compositors implement other protocols with similar events and enums (cosmic-toplevel-management for COSMIC, plasma-window-management for KWin etc.). |
Partially resolves #35
Added a config variable disable_when_fullscreen. When set to true (default), waycorner won't activate when a window is fully fullscreen (maybe default of false is better?). Only added for hyprland, but setup is there to extend to sway etc. Also if ran with --preview the corners will still be visible when fullscreen, should be a non-issue if --preview is only used for debugging.