Skip to content

Update ConfigMgrClientHealth.ps1 with version type for client version variables #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheAncientAnimal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ConfigMgrClientHealth.ps1 with version type for client version variables #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ConfigMgrClientHealth.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,11 +1255,11 @@ Begin {

Function Test-ClientVersion {
Param([Parameter(Mandatory=$true)]$Log)
$ClientVersion = Get-XMLConfigClientVersion
[Version]$ClientVersion = Get-XMLConfigClientVersion
[String]$ClientAutoUpgrade = Get-XMLConfigClientAutoUpgrade
$ClientAutoUpgrade = $ClientAutoUpgrade.ToLower()
$installedVersion = Get-ClientVersion
$log.ClientVersion = $installedVersion
[Version]$installedVersion = Get-ClientVersion
$log.ClientVersion = $installedVersion.ToString()

if ($installedVersion -ge $ClientVersion) {
$text = 'ConfigMgr Client version is: ' +$installedVersion + ': OK'
Expand Down Expand Up @@ -3467,10 +3467,10 @@ Process {
$log.CacheSize = Get-ClientCache

# Verify that installed client version is now equal or better that minimum required client version
$NewClientVersion = Get-ClientVersion
$MinimumClientVersion = Get-XMLConfigClientVersion
[Version]$NewClientVersion = Get-ClientVersion
[Version]$MinimumClientVersion = Get-XMLConfigClientVersion

if ( $NewClientVersion -lt $MinimumClientVersion) {
if ($NewClientVersion -lt $MinimumClientVersion) {
# ConfigMgr client version is still not at expected level.
# Log for now, remediation is comming
$Log.ClientInstalledReason += " Upgrade failed."
Expand Down