Skip to content

Fix duplicate node_label aggregation by deduplicating before string_a… #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrnz merged 1 commit into from
Jan 27, 2026
Merged

Fix duplicate node_label aggregation by deduplicating before string_a… #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 60 additions & 46 deletions mapserver/competency/queries.d/query_27.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,55 +38,69 @@ queries:
),

sckan_labels AS (
SELECT
nm.sckan_id,
nm.sckan_node_id,
string_agg(pt.label, ', ' ORDER BY seq.pos) AS sckan_node_label
FROM node_mappings nm
JOIN path_node_features pnf
ON nm.sckan_id = pnf.source_id
AND nm.path_id = pnf.path_id
AND nm.sckan_node_id = pnf.node_id
JOIN feature_terms pt
ON pnf.source_id = pt.source_id
AND pnf.feature_id = pt.term_id
CROSS JOIN LATERAL (
SELECT pos
FROM (
SELECT pnf.node_id::jsonb->>0 AS value, 1 AS pos
UNION ALL
SELECT value, ordinality + 1 AS pos
FROM jsonb_array_elements_text(pnf.node_id::jsonb->1) WITH ORDINALITY
) s
WHERE s.value = pt.term_id
) AS seq
GROUP BY nm.sckan_id, nm.sckan_node_id
SELECT
sckan_id,
sckan_node_id,
string_agg(label, ', ' ORDER BY pos) AS sckan_node_label
FROM (
SELECT DISTINCT
nm.sckan_id,
nm.sckan_node_id,
pt.label,
seq.pos
FROM node_mappings nm
JOIN path_node_features pnf
ON nm.sckan_id = pnf.source_id
AND nm.path_id = pnf.path_id
AND nm.sckan_node_id = pnf.node_id
JOIN feature_terms pt
ON pnf.source_id = pt.source_id
AND pnf.feature_id = pt.term_id
CROSS JOIN LATERAL (
SELECT pos
FROM (
SELECT pnf.node_id::jsonb->>0 AS value, 1 AS pos
UNION ALL
SELECT value, ordinality + 1 AS pos
FROM jsonb_array_elements_text(pnf.node_id::jsonb->1) WITH ORDINALITY
) s
WHERE s.value = pt.term_id
) seq
) AS dedup
GROUP BY sckan_id, sckan_node_id
),

map_labels AS (
SELECT
nm.source_id,
nm.node_id,
string_agg(pt.label, ', ' ORDER BY seq.pos) AS node_label
FROM node_mappings nm
JOIN path_node_features pnf
ON nm.source_id = pnf.source_id
AND nm.path_id = pnf.path_id
AND nm.node_id = pnf.node_id
JOIN feature_terms pt
ON pnf.source_id = pt.source_id
AND pnf.feature_id = pt.term_id
CROSS JOIN LATERAL (
SELECT pos
FROM (
SELECT pnf.node_id::jsonb->>0 AS value, 1 AS pos
UNION ALL
SELECT value, ordinality + 1 AS pos
FROM jsonb_array_elements_text(pnf.node_id::jsonb->1) WITH ORDINALITY
) s
WHERE s.value = pt.term_id
) AS seq
GROUP BY nm.source_id, nm.node_id
SELECT
source_id,
node_id,
string_agg(label, ', ' ORDER BY pos) AS node_label
FROM (
SELECT DISTINCT
nm.source_id,
nm.node_id,
pt.label,
seq.pos
FROM node_mappings nm
JOIN path_node_features pnf
ON nm.source_id = pnf.source_id
AND nm.path_id = pnf.path_id
AND nm.node_id = pnf.node_id
JOIN feature_terms pt
ON pnf.source_id = pt.source_id
AND pnf.feature_id = pt.term_id
CROSS JOIN LATERAL (
SELECT pos
FROM (
SELECT pnf.node_id::jsonb->>0 AS value, 1 AS pos
UNION ALL
SELECT value, ordinality + 1 AS pos
FROM jsonb_array_elements_text(pnf.node_id::jsonb->1) WITH ORDINALITY
) s
WHERE s.value = pt.term_id
) seq
) AS dedup
GROUP BY source_id, node_id
)

SELECT
Expand Down