Skip to content

Fix incorrect loop variable handling in substring removal step #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gloria-trivitt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect loop variable handling in substring removal step #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/transformations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,15 @@ def _build_substring_removal_clauses(client: bigquery.Client, source_table: str,

# Identify columns that need substring removal
subset_columns = []
for col in all_columns:
for col in subset_columns:
# Skip already processed columns
if col.lower() in processed_columns:
continue


# Skip loop variables so they get processed in the loop variable step
if utils.extract_loop_number(col) is not None:
continue

# Check if any substring from constants.SUBSTRINGS_TO_FIX is in the column name
if any(substring in col for substring in constants.SUBSTRINGS_TO_FIX):
subset_columns.append(col)
Expand Down