poc: Rich Tables#652
Draft
VincentSmedinga wants to merge 7 commits into
Draft
Conversation
# Conflicts: # package-lock.json # package.json # Conflicts: # package-lock.json # package.json
Moves the Label + Select into Table.Caption so the sort control is visually scoped to the table it acts on, as suggested by Inge. Uses explicit flexbox on the wrapper div rather than the Row component to avoid overflow clipping inside the caption element.
Replaces useState with useSearchParams so the active sort order is reflected in the URL (?sortering=…) and can be shared or bookmarked. Wraps the Select in a <form> with a visually hidden submit button for correct form semantics, as suggested by Aram.
Field names appear in URL query parameters (e.g. ?sortering=positie-asc), so they should be readable for Dutch-speaking users. Properties are also reordered to match the table column order. position → positie name → naam played → gespeeld won → gewonnen drawn → gelijk lost → verloren points → punten goals_for → doelpunten_voor goals_against → doelpunten_tegen goal_difference → doelsaldo
Shows sorting with inline links as an alternative to the Select, for tables with a small number of sort options. The active link is marked with aria-current and styled as bold without underline.
Sort state is now URL-driven via query parameters, matching the other prototypes. Each column header becomes a Link that toggles between ascending and descending when clicked (defaulting to ascending for a fresh column). aria-sort is set on the active <th> for accessibility.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few experiments with our Table components, a large data set, and various ways to manipulate or view.