3/7: Implement pattern & gradient paint servers#10
Merged
Conversation
This was referenced May 27, 2026
Amnell
force-pushed
the
pr/02-docs-and-tooling
branch
from
e1ff04d to
fd34b29
Compare
…ers-grad-03-b) - Add SVGPattern model (SVGPaint subclass) with CGBitmapContext tile rendering - Add draw(in: CGContext) to SVGNode (no-op), SVGRect, and SVGGroup - Add SVGParser.parseElements(_:index:) internal helper for pattern tile parsing - Register <pattern> elements as paint servers in SVGIndex with xlink:href inheritance - Wire SVGPattern into SVGPaint.apply(paint:model:) switch - Add pserversGrad03B test and reference file
- SVGPattern.apply() now uses Canvas-based tiling when patternTransform != .identity Computes inverse-transform bounds to determine exact tile coverage; falls back to cheaper ImagePaint path for identity transforms - Add pserversGrad06B test and reference file
…itmapContext Previously the parser baked gradientTransform into cx/cy/r, which only worked for uniform scale+translate and silently dropped skew/rotation (shear). Changes: - SVGRadialGradient now stores gradientTransform: CGAffineTransform (default .identity) - Parser no longer transforms the gradient points; raw gradient-space cx/cy/fx/fy/r are preserved and gradientTransform is passed directly to the model - SVGRadialGradient.apply() uses a CGBitmapContext path when gradientTransform is non-identity: sets up y-flip + shape-offset CTM, concatenates gradientTransform, then calls drawRadialGradient in gradient space so CoreGraphics handles the full affine deformation (translate, scale, skewX/Y, rotate, arbitrary matrix) - Falls back to the existing SwiftUI RadialGradient path for identity transforms Fixes the pservers-grad-06-b skewX(45) radial gradient rendering.
Amnell
force-pushed
the
pr/03-pattern-gradient-paint
branch
from
1cc27b0 to
e77ab96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement SVG pattern and gradient paint server rendering with full transform support.
Changes
xlink:hrefinheritance (pservers-grad-03-b)patternTransformsupport; add pservers-grad-06-bradialGradientgradientTransform: store transform, render via CGBitmapContextMerge order
main.Stack: