Skip to content

Added URL to component and field type mismatch error messages #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droqen wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

Added URL to component and field type mismatch error messages #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba22834
Added URL to component and field type mismatch error messages
droqen Nov 23, 2023
50f0e1d
changed url to docs hosted on ambient.run
droqen Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shared_crates/package_semantic/src/component.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ impl Resolve for Component {
.get_contextual_type_id(parent_id, ty)
.with_context(|| {
format!(
"Failed to resolve type `{ty:?}` for component `{}`",
self.data.id
"Failed to resolve type `{ty:?}` for component `{}`\nSee {} for valid types",
self.data.id,
"https://ambient.run/docs/reference/package#valuetype"
)
})?,
ResolvableItemId::Resolved(id) => *id,
Expand Down
6 changes: 5 additions & 1 deletion shared_crates/package_semantic/src/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ impl Resolve for Message {
match type_ {
ResolvableItemId::Unresolved(path) => {
let id = semantic.get_contextual_type_id(parent_id, path).with_context(|| {
format!("Failed to resolve type `{path:?}` for field `{name}` of message `{}`", self.data.id)
format!(
"Failed to resolve type `{path:?}` for field `{name}` of message `{}`\nSee {} for valid types",
self.data.id,
"https://ambient.run/docs/reference/package#valuetype"
)
})?;
ResolvableItemId::Resolved(id)
}
Expand Down