Conversation
|
@NITYANIT is attempting to deploy a commit to the Aman Singh's projects Team on Vercel. A member of the Team first needs to authorize it. |
📋 PR Checklist ReviewThank you for your contribution! Please address the following items: Required Actions❌ Missing Description: Please provide a clear description of your changes Please edit your PR description to complete all required items. Once done, this check will automatically pass! ✅ Need help? Check out our Contributing Guidelines or ask in the comments! |
There was a problem hiding this comment.
SECTION 1: FOR CONTRIBUTOR (@NITYANIT)
Hey! Good job on the FAQ design. It looks really nice. But we need to clean up the code so it is easier to work with.
Here is what you need to change:
Problem 1: Move Code to New File Location
Location: components/LandingPage.tsx Lines: 424 to 651
The file is too big. Please move the FAQ code to a new component.
Create Folder: components/LandingPage/FAQSection
Create File: components/LandingPage/FAQSection/index.tsx
Then import this new component into LandingPage.tsx.
Problem 2: Do Not Copy Paste Code
Location: components/LandingPage.tsx Lines: 435, 490, 545
You wrote the same code structure 3 times for 3 questions. Please use a list (array) of questions and map (loop) through them. This makes the code much smaller and cleaner.
Example:
const faqItems = [
{ question: 'What is...?', answer: 'Answer 1' },
{ question: 'How do...?', answer: 'Answer 2' },
{ question: 'Why...?', answer: 'Answer 3' }
]
Then use: {faqItems.map((item) => <FAQItem key={item.question} {...item} />)}
Problem 3: Fix Wrong Email
Location: components/LandingPage.tsx Line: 622
You used support@yourdomain.com. Please change this to the real support email or remove the link.
get the mail form the admin
FILES TO CHANGE:
- components/LandingPage.tsx (remove lines 424-651 and import new component)
FILES TO ADD:
- components/LandingPage/FAQSection/index.tsx (NEW)
STEPS TO FIX:
- Create the new folder and file
- Move FAQ code there
- Use array and map instead of copy paste
- Fix the email
- Push changes
- Come back and ask for review again
After you fix these, we can check it again.
SECTION 2: FOR ADMIN (Amansingh0807)
Hi Aman! The design looks good. But the code is not clean because it is all in one file. I asked the contributor to move the code to a separate file and fix the email.
CURRENT STATUS:
- Code needs to be moved to separate component file
- Email needs to be fixed
- Vercel authorization needed
WHAT YOU NEED TO DO:
Step 1: Wait for Contributor to Fix Code
The contributor (NITYANIT) needs to:
- Create components/LandingPage/FAQSection/index.tsx
- Move FAQ code there
- Use array and map for questions
- Fix the email
- Push the fixes
Step 2: Authorize Vercel
You need to authorize Vercel to deploy.
- Look for the Vercel message in comments
- Click the "authorize it" link
- This allows preview deployment when code is fixed
DO NOT MERGE YET:
Wait for all fixes to be completed first.
Estimated time: 2-3 hours
|
Thank you @asrith2208 for pointing out, also we actually don't require the changes in the Readme file. |
Fixes #52