Skip to content

Comments

Faqsection#55

Open
NITYANIT wants to merge 5 commits intoAmansingh0807:masterfrom
NITYANIT:faqsection
Open

Faqsection#55
NITYANIT wants to merge 5 commits intoAmansingh0807:masterfrom
NITYANIT:faqsection

Conversation

@NITYANIT
Copy link
Contributor

Fixes #52

@vercel
Copy link
Contributor

vercel bot commented Jan 17, 2026

@NITYANIT is attempting to deploy a commit to the Aman Singh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

📋 PR Checklist Review

Thank you for your contribution! Please address the following items:

Required Actions

Missing Description: Please provide a clear description of your changes
Type of Change: Please check at least one type of change
Contributing Guidelines: Please confirm you have read CONTRIBUTING.md
Self Review: Please perform a self-review of your code
AI Disclosure: Please indicate whether you used AI tools (Yes/No checkbox)


Please edit your PR description to complete all required items. Once done, this check will automatically pass! ✅

Need help? Check out our Contributing Guidelines or ask in the comments!

@github-actions github-actions bot added documentation Improvements or additions to documentation size/L UI/UX Improving the UI/UX labels Jan 17, 2026
Copy link
Collaborator

@asrith2208 asrith2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SECTION 1: FOR CONTRIBUTOR (@NITYANIT)

Hey! Good job on the FAQ design. It looks really nice. But we need to clean up the code so it is easier to work with.

Here is what you need to change:

Problem 1: Move Code to New File Location
Location: components/LandingPage.tsx Lines: 424 to 651
The file is too big. Please move the FAQ code to a new component.

Create Folder: components/LandingPage/FAQSection
Create File: components/LandingPage/FAQSection/index.tsx
Then import this new component into LandingPage.tsx.

Problem 2: Do Not Copy Paste Code
Location: components/LandingPage.tsx Lines: 435, 490, 545
You wrote the same code structure 3 times for 3 questions. Please use a list (array) of questions and map (loop) through them. This makes the code much smaller and cleaner.

Example:
const faqItems = [
{ question: 'What is...?', answer: 'Answer 1' },
{ question: 'How do...?', answer: 'Answer 2' },
{ question: 'Why...?', answer: 'Answer 3' }
]

Then use: {faqItems.map((item) => <FAQItem key={item.question} {...item} />)}

Problem 3: Fix Wrong Email
Location: components/LandingPage.tsx Line: 622
You used support@yourdomain.com. Please change this to the real support email or remove the link.
get the mail form the admin

FILES TO CHANGE:

  • components/LandingPage.tsx (remove lines 424-651 and import new component)

FILES TO ADD:

  • components/LandingPage/FAQSection/index.tsx (NEW)

STEPS TO FIX:

  1. Create the new folder and file
  2. Move FAQ code there
  3. Use array and map instead of copy paste
  4. Fix the email
  5. Push changes
  6. Come back and ask for review again

After you fix these, we can check it again.


SECTION 2: FOR ADMIN (Amansingh0807)

Hi Aman! The design looks good. But the code is not clean because it is all in one file. I asked the contributor to move the code to a separate file and fix the email.

CURRENT STATUS:

  • Code needs to be moved to separate component file
  • Email needs to be fixed
  • Vercel authorization needed

WHAT YOU NEED TO DO:

Step 1: Wait for Contributor to Fix Code
The contributor (NITYANIT) needs to:

  1. Create components/LandingPage/FAQSection/index.tsx
  2. Move FAQ code there
  3. Use array and map for questions
  4. Fix the email
  5. Push the fixes

Step 2: Authorize Vercel
You need to authorize Vercel to deploy.

  1. Look for the Vercel message in comments
  2. Click the "authorize it" link
  3. This allows preview deployment when code is fixed

DO NOT MERGE YET:
Wait for all fixes to be completed first.

Estimated time: 2-3 hours

@Amansingh0807
Copy link
Owner

Thank you @asrith2208 for pointing out, also we actually don't require the changes in the Readme file.
@NITYANIT Make sure you upstream the changes while creating a New Branch for any PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Need Changes size/L UI/UX Improving the UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: enhancement of FAQ section

3 participants