fix: Update Figma prototype link and text in footer #18059
Conversation
Point the design resource to the Figma community file and simplify the Norwegian copy for the dashboard design resource. Updated Resources.tsx to use the new Figma URL and modified src/Designer/frontend/language/src/nb.json to change the dashboard.resource_design_label and dashboard.resource_design_description to reference prototyping in Figma.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the dashboard design resource reference by changing the Figma URL in the Resources component and refines two Norwegian localization strings: the label changed to "Prototype i Figma" and the description to a concise sentence about creating Altinn service prototypes in Figma. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Designer/frontend/dashboard/components/Resources/Resources.tsx`:
- Line 39: The inline Figma URL literal used in the resource map inside
Resources.tsx should be extracted to a descriptive constant (e.g.,
FIGMA_COMMUNITY_FILE_URL) instead of being hard-coded; create the constant at
the top of the module (or in the shared ext-urls helper and export it), replace
the url: 'https://www.figma.com/community/file/1344307804742953785' entry in the
resource map with that constant, and update any imports/usages to reference the
new named constant to keep links maintainable and follow the "no hard-coded
strings" guideline.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cf971943-4982-4878-898a-443a790db7d2
📒 Files selected for processing (2)
src/Designer/frontend/dashboard/components/Resources/Resources.tsxsrc/Designer/frontend/language/src/nb.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18059 +/- ##
==========================================
- Coverage 95.20% 95.19% -0.02%
==========================================
Files 2505 2507 +2
Lines 32588 32621 +33
Branches 3869 3871 +2
==========================================
+ Hits 31025 31053 +28
- Misses 1218 1224 +6
+ Partials 345 344 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merge commits are not allowed on this repository
Point the design resource to the Figma community file and simplify the Norwegian copy for the dashboard design resource. Updated Resources.tsx to use the new Figma URL and modified src/Designer/frontend/language/src/nb.json to change the dashboard.resource_design_label and dashboard.resource_design_description to reference prototyping in Figma.
Description
before

After
Verification
Summary by CodeRabbit
Documentation
Chores