Skip to content

updated docs for both languages - system register#2619

Open
Nyeng wants to merge 1 commit intomasterfrom
fix/update-system-register
Open

updated docs for both languages - system register#2619
Nyeng wants to merge 1 commit intomasterfrom
fix/update-system-register

Conversation

@Nyeng
Copy link
Copy Markdown
Contributor

@Nyeng Nyeng commented Jan 12, 2026

Summary by CodeRabbit

  • Documentation
    • Clarified system register update endpoint documentation with improved examples and concrete sample values.
    • Added guidance on the isVisible flag default behavior for production and testing scenarios.
    • Enhanced error code documentation with standardized formatting and consistent descriptions.
    • Introduced new sections documenting system rights and access packages update endpoints with complete request examples.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 12, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

Documentation updates to the system register update endpoint for two language variants. Changes include replacing empty example values with concrete strings, standardizing error code tables, adding clarifying notes about the isVisible field defaulting to false, expanding payload examples with new fields, and introducing new sections for system rights and access packages.

Changes

Cohort / File(s) Summary
API Documentation Updates
content/api/authentication/systemuserapi/systemregister/update/_index.en.md
Standardizes error code table formatting and wording; replaces empty resource values with concrete strings; toggles isVisible from true to false; adds clarifying note that isVisible should be false for production/vendor testing; updates rights example replacing one resource value
API Documentation Updates
content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
Expands update endpoint documentation with new payload fields (accessPackages, allowedRedirectUrls); replaces empty fields with sample data; adds note clarifying isVisible defaults to false in examples; introduces new sections for updating system rights and access packages; standardizes error code table styling and wording; adjusts example payloads for consistency

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

📚 Examples bloomed with values true,
Across two tongues, the docs renewed,
False flags set for testing's way,
Rights and packages on display! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'updated docs for both languages - system register' directly corresponds to the changeset, which updates documentation for both English and Norwegian Bokmål related to the system register update endpoint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Fix all issues with AI agents
In @content/api/authentication/systemuserapi/systemregister/update/_index.nb.md:
- Line 27: The heading level for "systemId" is incorrectly h4 following the h2
"Argumenter"; change the "#### systemId" heading to h3 ("### systemId") so
headings increment by one level from "## Argumenter" to "### systemId" to follow
Markdown hierarchy consistency.
- Around line 211-230: The fenced code block containing the JSON array (starts
with "[" and the two resource objects) lacks a language tag; update the opening
fence from ``` to ```json so the block is ```json\n[ ... ]``` to enable proper
JSON syntax highlighting in the markdown file and ensure the example is rendered
correctly.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5a6f7d and ba54f78.

📒 Files selected for processing (2)
  • content/api/authentication/systemuserapi/systemregister/update/_index.en.md
  • content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*

⚙️ CodeRabbit configuration file

Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).

Files:

  • content/api/authentication/systemuserapi/systemregister/update/_index.en.md
  • content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
**/*.nb.md

⚙️ CodeRabbit configuration file

Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.

Files:

  • content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
🧠 Learnings (2)
📓 Common learnings
Learnt from: lvbachmann
Repo: Altinn/altinn-studio-docs PR: 2477
File: content/authorization/migration/servicemigrationplan/_index.nb.md:4-4
Timestamp: 2025-10-27T07:48:11.643Z
Learning: In content/authorization/migration/servicemigrationplan/_index.nb.md (Norwegian Bokmål), the use of "Altinn II" in the description and "Altinn 2" in the document body is intentional and reflects actual naming conventions. This terminology difference should not be flagged as an inconsistency.
Learnt from: mSunberg
Repo: Altinn/altinn-studio-docs PR: 0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.
Learnt from: SandGrainOne
Repo: Altinn/altinn-studio-docs PR: 2262
File: static/swagger/altinn-platform-profile-v1.json:202-296
Timestamp: 2025-07-11T09:46:22.736Z
Learning: The file static/swagger/altinn-platform-profile-v1.json is mostly autogenerated and manually added to documentation. Any issues with this OpenAPI specification file need to be fixed in the source code that generates it, not directly in the file itself.
📚 Learning: 2025-08-13T07:02:55.898Z
Learnt from: Ahmed-Ghanam
Repo: Altinn/altinn-studio-docs PR: 2308
File: static/swagger/altinn-notifications-v1.json:186-247
Timestamp: 2025-08-13T07:02:55.898Z
Learning: The InstantOrdersController in the Altinn Notifications API uses different validation error handling than the regular orders endpoint - it uses 400 for all validation errors rather than separating them with 422 (Unprocessable Entity). The OpenAPI specification should reflect the actual controller implementation.

Applied to files:

  • content/api/authentication/systemuserapi/systemregister/update/_index.en.md
🪛 LanguageTool
content/api/authentication/systemuserapi/systemregister/update/_index.en.md

[style] ~90-~90: Consider using the typographical ellipsis character here instead.
Context: ...does not match the format orgnumber_xxxx... ...

(ELLIPSIS)


[uncategorized] ~93-~93: Do not mix variants of the same word (‘organisation’ and ‘organization’) within a single text.
Context: ... | The ClientId can be tied to only one organisation. The vendor must use a different client...

(EN_WORD_COHERENCY)


[typographical] ~94-~94: To join two clauses or introduce examples, consider using an em dash.
Context: ...://xxx.xx | - ...

(DASH_RULE)


[typographical] ~98-~98: To join two clauses or introduce examples, consider using an em dash.
Context: ...urce | - ...

(DASH_RULE)


[typographical] ~99-~99: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~100-~100: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~101-~101: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~102-~102: To join two clauses or introduce examples, consider using an em dash.
Context: ...gable. | - ...

(DASH_RULE)

🪛 markdownlint-cli2 (0.18.1)
content/api/authentication/systemuserapi/systemregister/update/_index.en.md

94-94: Bare URL used

(MD034, no-bare-urls)

content/api/authentication/systemuserapi/systemregister/update/_index.nb.md

27-27: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4

(MD001, heading-increment)


93-93: Bare URL used

(MD034, no-bare-urls)


211-211: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (5)
content/api/authentication/systemuserapi/systemregister/update/_index.en.md (3)

43-78: Documentation improvements look good!

The updates to provide concrete example values (resource names, allowedRedirectUrls) and the clarifying note about isVisible: false for testing make this documentation more helpful and actionable for developers.


152-198: Consistent use of isVisible: false in examples.

The examples correctly reflect the testing approach mentioned in the note at lines 77-78.


202-268: Valuable additions for partial update endpoints.

The new sections for updating system rights and access packages provide clear, focused documentation for these specific operations. The structure and format are consistent with the rest of the document.

content/api/authentication/systemuserapi/systemregister/update/_index.nb.md (2)

43-83: Gode forbedringer i dokumentasjonen!

The updates provide concrete example values and a helpful note about isVisible: false for testing. The Norwegian text is grammatically correct and clear.


240-267: Nyttig tillegg for oppdatering av tilgangspakker.

The new section for updating access packages provides clear documentation consistent with the English version. The Norwegian text is grammatically correct and well-structured.

Comment on lines +87 to +103
| Error Code | Status Code | Error Message | Detailed Description |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | When you create a system user via the UI, the system in the system register must have isVisible: true. This only applies to own (standard) system users, where rights are delegated directly to the system user in the creation process. Client-relationship-specific access packages cannot be combined with isVisible: true, because these packages are not delegable. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Address spelling consistency and incomplete error descriptions.

Two issues in the error code table:

  1. Spelling inconsistency: Line 93 uses "organisation" (British) while "organization" (American) is used elsewhere in the documentation. Choose one variant and use it consistently.

  2. Missing descriptions: Lines 94, 98, 99, 100, 101, and 102 use "-" as placeholders in the "Detailed Description" column. Consider adding actual descriptions or using "N/A" or similar to indicate no additional details are available.

Suggested fix for spelling consistency
-| AUTH.VLD-00004 | 400         | One of the client id is already tagged with an existing system                                                        | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system.                                                                                                                                                                                                                                                         |
+| AUTH.VLD-00004 | 400         | One of the client id is already tagged with an existing system                                                        | The ClientId can be tied to only one organization. The vendor must use a different client id for the new system.                                                                                                                                                                                                                                                         |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| Error Code | Status Code | Error Message | Detailed Description |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | When you create a system user via the UI, the system in the system register must have isVisible: true. This only applies to own (standard) system users, where rights are delegated directly to the system user in the creation process. Client-relationship-specific access packages cannot be combined with isVisible: true, because these packages are not delegable. |
| Error Code | Status Code | Error Message | Detailed Description |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organization. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | When you create a system user via the UI, the system in the system register must have isVisible: true. This only applies to own (standard) system users, where rights are delegated directly to the system user in the creation process. Client-relationship-specific access packages cannot be combined with isVisible: true, because these packages are not delegable. |
🧰 Tools
🪛 LanguageTool

[style] ~90-~90: Consider using the typographical ellipsis character here instead.
Context: ...does not match the format orgnumber_xxxx... ...

(ELLIPSIS)


[uncategorized] ~93-~93: Do not mix variants of the same word (‘organisation’ and ‘organization’) within a single text.
Context: ... | The ClientId can be tied to only one organisation. The vendor must use a different client...

(EN_WORD_COHERENCY)


[typographical] ~94-~94: To join two clauses or introduce examples, consider using an em dash.
Context: ...://xxx.xx | - ...

(DASH_RULE)


[typographical] ~98-~98: To join two clauses or introduce examples, consider using an em dash.
Context: ...urce | - ...

(DASH_RULE)


[typographical] ~99-~99: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~100-~100: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~101-~101: To join two clauses or introduce examples, consider using an em dash.
Context: ... | - ...

(DASH_RULE)


[typographical] ~102-~102: To join two clauses or introduce examples, consider using an em dash.
Context: ...gable. | - ...

(DASH_RULE)

🪛 markdownlint-cli2 (0.18.1)

94-94: Bare URL used

(MD034, no-bare-urls)


## Argumenter

#### systemId
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix heading level increment.

The heading jumps from h2 (## Argumenter at line 25) to h4 (#### systemId). Markdown best practices require heading levels to increment by one level at a time.

Proposed fix
-#### systemId
+### systemId
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#### systemId
### systemId
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

27-27: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4

(MD001, heading-increment)

🤖 Prompt for AI Agents
In @content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
at line 27, The heading level for "systemId" is incorrectly h4 following the h2
"Argumenter"; change the "#### systemId" heading to h3 ("### systemId") so
headings increment by one level from "## Argumenter" to "### systemId" to follow
Markdown hierarchy consistency.

Comment on lines +86 to +102
| Feil Kode | Status Kode | Feil melding | Detaljert beskrivelse |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | Når du oppretter en systembruker via brukerflaten, må systemet i Systemregisteret være satt til isVisible: true. Dette gjelder kun for egen (standard) systembruker, der rettigheter delegeres direkte til systembrukeren i opprettelsesprosessen. Klientdelegeringsspesifikke tilgangspakker kan ikke kombineres med isVisible: true, fordi disse pakkene ikke er delegerbare. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Address spelling consistency and incomplete error descriptions.

Same issues as in the English version:

  1. Spelling inconsistency: Line 92 uses "organisation" (British) while "organization" (American) is used elsewhere. Maintain consistency across both language versions.

  2. Missing descriptions: Lines 93, 97, 98, 99, 100, and 101 use "-" as placeholders. Consider adding actual descriptions or using "N/A" to indicate no additional details are available.

Suggested fix for spelling consistency
-| AUTH.VLD-00004 | 400         | One of the client id is already tagged with an existing system                                                        | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system.                                                                                                                                                                                                                                                                |
+| AUTH.VLD-00004 | 400         | One of the client id is already tagged with an existing system                                                        | The ClientId can be tied to only one organization. The vendor must use a different client id for the new system.                                                                                                                                                                                                                                                                |
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
| Feil Kode | Status Kode | Feil melding | Detaljert beskrivelse |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organisation. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | Når du oppretter en systembruker via brukerflaten, må systemet i Systemregisteret være satt til isVisible: true. Dette gjelder kun for egen (standard) systembruker, der rettigheter delegeres direkte til systembrukeren i opprettelsesprosessen. Klientdelegeringsspesifikke tilgangspakker kan ikke kombineres med isVisible: true, fordi disse pakkene ikke er delegerbare. |
| Feil Kode | Status Kode | Feil melding | Detaljert beskrivelse |
| -------------- | ----------- | --------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| AUTH.VLD-00000 | 400 | the org number identifier is not valid ISO6523 identifier | The organization identifier must be 0192, f.ex 0192:991825827 |
| AUTH.VLD-00001 | 400 | The system id does not match the format orgnumber_xxxx... | The systemid is expected to be in the format vendororgnumber_xxxxxx |
| AUTH.VLD-00002 | 400 | The system id already exists | The system id is already taken |
| AUTH.VLD-00003 | 400 | One or more resources specified in rights were not found in Altinn's resource register. | Any service outside altinn must be registered as a resource in altinn's resource register. Either the service provider has failed to register the resource or is specified wrong in the system register request. |
| AUTH.VLD-00004 | 400 | One of the client id is already tagged with an existing system | The ClientId can be tied to only one organization. The vendor must use a different client id for the new system. |
| AUTH.VLD-00005 | 400 | One or more of the redirect urls format is not valid. The valid format is https://xxx.xx | - |
| AUTH.VLD-00006 | 400 | One or more duplicate rights found | Check your rights section and eliminate any duplicate app/resource |
| AUTH.VLD-00007 | 400 | One or more duplicate access package(s) found | The system id is already taken |
| AUTH.VLD-00008 | 400 | One or all the accesspackage(s) is not found in altinn's access packages or is not delegable | The system id is already taken |
| AUTH.VLD-00009 | 400 | One or more resource id is in wrong format. The valid format is urn:altinn:resource | - |
| AUTH.VLD-00011 | 400 | Request contains duplicate client ids | - |
| AUTH.VLD-00012 | 400 | The system ID in the request body does not match the system ID in the URL | - |
| AUTH.VLD-00013 | 400 | System ID cannot have spaces in id (leading, trailing or in between the id) | - |
| AUTH.VLD-00017 | 400 | One or more resources specified in rights is of resource type which is not delegable. | - |
| AUTH.VLD-00018 | 400 | Access packages meant for system user for client relations can't be used in combination with the flag isVisible: true | Når du oppretter en systembruker via brukerflaten, må systemet i Systemregisteret være satt til isVisible: true. Dette gjelder kun for egen (standard) systembruker, der rettigheter delegeres direkte til systembrukeren i opprettelsesprosessen. Klientdelegeringsspesifikke tilgangspakker kan ikke kombineres med isVisible: true, fordi disse pakkene ikke er delegerbare. |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

93-93: Bare URL used

(MD034, no-bare-urls)

Comment on lines 211 to 230
```
[
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
},
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
}
]
}
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
}
]
},
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "ske-krav-og-betalinger"
}
]
}
]
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add language specification to code block.

The fenced code block at line 211 should specify the language for proper syntax highlighting.

Proposed fix
-```
+```json
 [
   {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```
[
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
},
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
}
]
}
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "authentication-e2e-test"
}
]
},
{
"resource": [
{
"id": "urn:altinn:resource",
"value": "ske-krav-og-betalinger"
}
]
}
]
```
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

211-211: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
In @content/api/authentication/systemuserapi/systemregister/update/_index.nb.md
around lines 211 - 230, The fenced code block containing the JSON array (starts
with "[" and the two resource objects) lacks a language tag; update the opening
fence from ``` to ```json so the block is ```json\n[ ... ]``` to enable proper
JSON syntax highlighting in the markdown file and ensure the example is rendered
correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant