Skip to content

feat: change signing data elements ordering#2408

Draft
vxkc wants to merge 2 commits intomasterfrom
feat/signing-document-list-ordering
Draft

feat: change signing data elements ordering#2408
vxkc wants to merge 2 commits intomasterfrom
feat/signing-document-list-ordering

Conversation

@vxkc
Copy link
Copy Markdown

@vxkc vxkc commented Oct 9, 2025

Add documentation for the changes requested in Altinn/app-frontend-react#3367, implemented in Altinn/app-lib-dotnet#1511 and Altinn/app-frontend-react#3775.

Summary by CodeRabbit

  • Documentation
    • Clarified SigningDocumentList table sorting: rows are ordered first by the configured dataTypesToSign order in the process, then by document creation date.
    • Updated both English and Norwegian documentation pages to include the expanded sorting details.
    • Retained the existing note that the attachment type can still be changed via tags.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 9, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'auto_resolve_threads'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

Documentation for SigningDocumentList updated in English and Norwegian Bokmål to describe table row sorting by dataTypesToSign order from process.bpmn, then by document creation date. No code or API changes. Please check documentation in en-US, nb-NO, and nn-NO.

Changes

Cohort / File(s) Summary
Docs: SigningDocumentList
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md, content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md
Added notes that rows are sorted by dataTypesToSign order from process.bpmn, then by creation date; retained existing note on attachment type changes. No logic/code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

Pages shuffled in tidy lines,
First by type the process defines—
Then by time, the newest gleam,
Docs fall neatly in a stream.
No code awoke, just words aligned;
Order told, intent refined.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “feat: change signing data elements ordering” clearly identifies the main change—adjusting the order of signing data elements—without extraneous detail, and it accurately reflects the documentation updates that describe the new sorting behavior. This phrasing is concise, specific, and directly tied to the primary intent of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/signing-document-list-ordering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a04b860 and fce43a6.

📒 Files selected for processing (2)
  • content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md (1 hunks)
  • content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
content/**/*

⚙️ CodeRabbit configuration file

Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).

Files:

  • content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md
  • content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md
**/*.nb.md

⚙️ CodeRabbit configuration file

Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.

Files:

  • content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.nb.md (1)

75-75: Juster flertallsformen for «opprettelsesdato».

Bytt ut «dokumentenes opprettelsesdato» med «dokumentenes opprettelsesdatoer» (eller «hver enkelt dokuments opprettelsesdato») slik at flertall samsvarer gjennom setningen.

⛔ Skipped due to learnings
Learnt from: mSunberg
PR: Altinn/altinn-studio-docs#0
File: :0-0
Timestamp: 2025-04-04T08:22:36.805Z
Learning: When reviewing Norwegian content (files with .nb.md or .nn.md extensions), carefully check for spelling and grammar issues, particularly watching for changes to specialized terminology like "Digitaliseringsrundskrivet" and Norwegian-specific words.

Comment thread content/altinn-studio/v8/reference/ux/components/SigningDocumentList/_index.en.md Outdated
Add documentation for the changes requested in
Altinn/app-frontend-react#3367
@vxkc vxkc force-pushed the feat/signing-document-list-ordering branch 2 times, most recently from e336a06 to f39c201 Compare October 9, 2025 15:22
@vxkc vxkc marked this pull request as ready for review October 10, 2025 06:37
@vxkc vxkc marked this pull request as draft October 10, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants