Kom i gang sophie

[sophiearntsen]

Summary by CodeRabbit

• Documentation
  • Overhauled Norwegian “Systembruker” getting-started content with step-by-step onboarding, clarified roles/flows, and listed required scopes.
  • Reworked Norwegian system vendor guide with new onboarding models, usage patterns, visuals; removed legacy step details.
  • Streamlined English system vendor guide by removing extensive reference setup sections.
  • Added demo client documentation (EN/NB) with reference implementation, setup steps, and example configuration.
  • Introduced “What do you get – System User” pages (EN/NB) explaining concepts, flows, and ecosystem.
  • Minor fixes: formatting cleanup and corrected links in Norwegian request guide.

[coderabbitai]

Walkthrough

Documentation revamp around “System User/Systembruker”: reorganized guides, added new overview pages (en/nb), introduced demo client docs (en/nb), refined getting-started and vendor guides, and made minor text/link fixes. No code or API changes; edits are purely content-focused, including updated scopes and onboarding references.

Changes

Cohort / File(s)	Summary of Changes
Getting Started (nb) content/authorization/getting-started/systemuser/_index.nb.md	Rewrote and reorganized onboarding text; added explicit Maskinporten steps, Norwegian org requirement, and listed scopes altinn:authentication/systemuser.request.read, .write, altinn:authentication/systemregister.write.
Vendor Guide — System User (en/nb) content/authorization/guides/system-vendor/system-user/_index.en.md, .../_index.nb.md	EN: removed detailed TT02 reference implementation/setup sections; retained core flows and examples. NB: restructured with new “Opprettelse”, clarified end-user vs provider-initiated models, usage patterns, updated visuals; removed legacy step lists and samples.
Demo Client (en/nb) content/authorization/guides/system-vendor/system-user/democlient/_index.en.md, .../democlient/_index.nb.md	Added new demo/reference implementation docs (C# console app): prerequisites, setup, onboarding, configuration, and sample code snippet fields.
System User Request (nb) content/authorization/guides/system-vendor/system-user/systemuserrequest/_index.nb.md	Minor formatting and typo fixes; corrected “Samarbeidsportalen” links; removed leading blank lines.
What Do You Get — System User (en/nb) content/authorization/what-do-you-get/systemuser/_index.en.md, .../_index.nb.md	New overview pages describing System User concept, roles, ecosystem components (Resource Owner, Altinn Authorization, System Registry, PDP, Maskinporten), flows, and delivery plan; includes related guide references.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Vendor as System Vendor
  participant EUS as End User System
  participant User as End User
  participant MP as Maskinporten
  participant AA as Altinn Authorization
  participant SR as System Registry
  participant PDP as PDP

  Note over Vendor,EUS: Leverandørstyrt opprettelse (provider-initiated)

  Vendor->>MP: Client assertion (JWT) -> Token (scope: systemuser.request.write)
  MP-->>Vendor: Access token
  Vendor->>AA: Create System User Request (incl. return URL)
  AA-->>Vendor: Request ID / approval URL
  Vendor->>User: Redirect to approval URL
  User->>AA: Authenticate & approve
  AA->>SR: Persist System User + permissions
  SR-->>AA: Confirm
  AA-->>EUS: Callback to return URL (approved/denied)

  Note over EUS,MP: Runtime use of System User

  EUS->>MP: JWT Grant -> Access token (scoped)
  MP-->>EUS: Access token (audience: Altinn/Service)
  EUS->>PDP: Authorization decision (subject=System User, delegation)
  PDP-->>EUS: Permit/Deny
  EUS->>AA: Invoke API with token (if Permit)
  AA-->>EUS: Response

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Updates sys doc reg system #2373 — Edits the same system-vendor system-user docs and adds related guide pages; likely part of the same restructuring.
• Språkvask og forenklet beskrivelse av systembruker #2347 — Overlapping rewrites to systemuser/systembruker onboarding and getting-started sections across languages.

Poem

New pages bloom where guides once sprawled,
A demo hums, the flows recalled.
Maskinporten’s gate, a token’s gleam,
Altinn’s checks align the stream.
Systembruker stands, concise and clear—
Docs refreshed; the path is near. 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “Kom i gang sophie” is a personal note that neither summarizes nor relates to the extensive documentation changes in this pull request, which include adding and restructuring system user onboarding guides, demo client documentation, and content in multiple languages. As a result, it fails to convey the primary content changes or purpose of the PR.	Please rename the pull request to a concise sentence that clearly reflects the main changes, for example “Add and restructure system user onboarding documentation in EN and NB.”

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kom-i-gang-sophie

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 8

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66eb88d and 03e5245.

⛔ Files ignored due to path filters (18)

• content/authorization/guides/system-vendor/eget_system.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/delegering1.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/delegering2.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/delegering3.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding1.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding2.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding3.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding4.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding5.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding6.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/democlient/onboarding7.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/eget_system.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/image-1.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/image-2.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/image-3.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/image-4.png is excluded by !**/*.png
• content/authorization/guides/system-vendor/system-user/klient_system.png is excluded by !**/*.png
• content/authorization/what-do-you-get/systemuser/runtime.png is excluded by !**/*.png

📒 Files selected for processing (8)

• content/authorization/getting-started/systemuser/_index.nb.md (1 hunks)
• content/authorization/guides/system-vendor/system-user/_index.en.md (0 hunks)
• content/authorization/guides/system-vendor/system-user/_index.nb.md (1 hunks)
• content/authorization/guides/system-vendor/system-user/democlient/_index.en.md (1 hunks)
• content/authorization/guides/system-vendor/system-user/democlient/_index.nb.md (1 hunks)
• content/authorization/guides/system-vendor/system-user/systemuserrequest/_index.nb.md (2 hunks)
• content/authorization/what-do-you-get/systemuser/_index.en.md (1 hunks)
• content/authorization/what-do-you-get/systemuser/_index.nb.md (1 hunks)

💤 Files with no reviewable changes (1)

• content/authorization/guides/system-vendor/system-user/_index.en.md

🧰 Additional context used

📓 Path-based instructions (2)

content/**/*

⚙️ CodeRabbit configuration file

Check for links, markdown formatting, headings, grammar, and spelling in multiple languages (en-US, nb-NO, nn-NO).

Files:

• content/authorization/what-do-you-get/systemuser/_index.en.md
• content/authorization/guides/system-vendor/system-user/democlient/_index.en.md
• content/authorization/guides/system-vendor/system-user/_index.nb.md
• content/authorization/guides/system-vendor/system-user/democlient/_index.nb.md
• content/authorization/what-do-you-get/systemuser/_index.nb.md
• content/authorization/guides/system-vendor/system-user/systemuserrequest/_index.nb.md
• content/authorization/getting-started/systemuser/_index.nb.md

**/*.nb.md

⚙️ CodeRabbit configuration file

Check for Norwegian Bokmål (nb-NO) grammar and spelling with extra care. Pay special attention to specialized terminology and Norwegian-specific words.

Files:

• content/authorization/guides/system-vendor/system-user/_index.nb.md
• content/authorization/guides/system-vendor/system-user/democlient/_index.nb.md
• content/authorization/what-do-you-get/systemuser/_index.nb.md
• content/authorization/guides/system-vendor/system-user/systemuserrequest/_index.nb.md
• content/authorization/getting-started/systemuser/_index.nb.md

🪛 markdownlint-cli2 (0.18.1)

content/authorization/what-do-you-get/systemuser/_index.en.md

35-35: Link text should be descriptive

(MD059, descriptive-link-text)

---

37-37: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

46-46: Link text should be descriptive

(MD059, descriptive-link-text)

---

48-48: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

53-53: Link text should be descriptive

(MD059, descriptive-link-text)

content/authorization/what-do-you-get/systemuser/_index.nb.md

37-37: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

48-48: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript-typescript)

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Mellomrom før lenke

Line 47 mangler mellomrom i “se[Maskinporten…]”. Sett inn mellomrom for korrekt typografi.

🤖 Prompt for AI Agents

In content/authorization/getting-started/systemuser/_index.nb.md around lines 45
to 48, the text "se[Maskinporten klient](...)" is missing a space before the
link; insert a single space so it reads "se [Maskinporten klient](...)" to fix
the typography and ensure proper Markdown/link spacing.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Stavefeil i “formål”

Line 87: “forkjellige frormål” bør være “forskjellige formål”.

🤖 Prompt for AI Agents

content/authorization/getting-started/systemuser/_index.nb.md around line 87:
fix the spelling typo in the sentence so that “forkjellige frormål” is replaced
with “forskjellige formål” (i.e., correct both misspelled words) keeping the
rest of the sentence and link unchanged.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Remove duplicated section

Paragraphs 21‑29 repeat the content already stated in 9‑27, and the heading at Line 30 is identical to Line 19. Please drop the duplicate block so the doc flows once.

🤖 Prompt for AI Agents

In
content/authorization/guides/system-vendor/system-user/democlient/_index.en.md
around lines 9 to 32, there is a duplicated block (lines 21–29 repeat lines 9–17
and the heading at line 30 duplicates the heading at line 19); remove the
repeated paragraphs (lines 21–29) and the duplicate heading (line 30) so the
reference implementation description appears only once and the document flows
correctly.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Unngå dobbelt overskrift

“Oppsett av referanseimplementasjon med egen konfigurasjon” står to ganger (Line 25 og 37). Fjern den dupliserte overskriften/punktet for å unngå forvirring.

🤖 Prompt for AI Agents

In
content/authorization/guides/system-vendor/system-user/democlient/_index.nb.md
around lines 25 to 40, there is a duplicated heading "Oppsett av
referanseimplementasjon med egen konfigurasjon" (appears at lines 25 and 37);
remove the second occurrence (the duplicate at ~line 37) and adjust surrounding
text so the flow and any list/numbering remain correct (remove the duplicate
heading and any redundant blank line so the following paragraph/list remains a
single coherent section).

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Make link text descriptive

Lines 35, 47, and 53 use “see [here]”, which markdownlint flags (MD059). Replace with meaningful link text, e.g., “See the resource-owner guide”, “See the system-vendor guide”, etc.

🧰 Tools

🪛 markdownlint-cli2 (0.18.1)

35-35: Link text should be descriptive

(MD059, descriptive-link-text)

---

37-37: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

46-46: Link text should be descriptive

(MD059, descriptive-link-text)

---

48-48: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

53-53: Link text should be descriptive

(MD059, descriptive-link-text)

🤖 Prompt for AI Agents

In content/authorization/what-do-you-get/systemuser/_index.en.md around lines
35-53, replace the three non-descriptive "see [here]" link texts to satisfy
MD059: change the link at line 35 to something like "See the resource-owner
guide" (keeping the existing href ./../../guides/resource-owner/system-user/),
change the link at line 47 to "See the system-vendor guide" (keeping href
./../../guides/system-vendor/system-user/), and change the link at line 53 to
"See the end-user guide" (keeping href ./../../guides/end-user/system-user/); do
not change the target URLs, only update the visible link text to be descriptive.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Flere skrivefeil i innledningen

Korriger blant annet “platformleverandører” → “plattformleverandører” (Line 9), manglende punktum etter Line 12, “suplere” → “supplere” (Line 17), “operasjonene … person bruk” → “operasjonene … personen må bruke” (Line 21), og “virksomhet … scope bruk” → “virksomheten … scope må bruke” (Line 24). Disse feilene svekker forståelsen av introen.

🧰 Tools

🪛 markdownlint-cli2 (0.18.1)

37-37: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🤖 Prompt for AI Agents

In content/authorization/what-do-you-get/systemuser/_index.nb.md around lines
9–43, fix several typos and awkward phrases: change “platformleverandører” to
“plattformleverandører” (line 9), add a missing period at the end of the
sentence after line 12, change “suplere” to “supplere” (line 17), replace
“operasjonene ... person bruk” with “operasjonene ... personen må bruke” (line
21), and replace “virksomhet ... scope bruk” with “virksomheten ... scope må
bruke” (line 24); ensure punctuation and spacing around these edits remain
consistent and run a quick spell/grammar check on the surrounding sentences for
any remaining minor issues.