feat(editor): Format button + Save flow (name popover, favorites, rename/delete)#7
Merged
BorisTyshkevich merged 2 commits intoJun 21, 2026
Conversation
…ame/delete)
Editor toolbar + Saved/History UX from the original design:
- Format ({ }) button → runs formatQuery (same as ⌘⇧Enter).
- Save button replaces the toolbar star. Click (or ⌘S) → "Save query as"
name popover, prefilled with the tab name or one inferred from the SQL.
Enter/Save creates the saved entry and LINKS the tab; the button then reads
"Saved" (accent) until the SQL is edited (dirty), and re-saving updates the
linked entry in place.
- Saved list: live count on the tab ("Saved · N"); each row has a favorite
star (toggle, favorites sort first), inline rename (pencil) and delete
(trash) instead of the old single ×.
- History rows: trash icon instead of × (matches Saved).
state.js: saveQuery (create-or-update + link), savedForTab, renameSaved,
toggleFavorite, sortedSaved replace the old toggleSaved/findSavedBySql.
icons.js: braces, bookmark, pencil, trash. shortcuts.js: ⌘S opens the popover.
npm test → 381 passing; state/saved-history/shortcuts/icons 100%, app.js gate met.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QennTvGKAtJZrv9EpQagef
braces now reuses the same path as the json icon so the toolbar Format button
renders identically to the { } JSON result-view tab.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QennTvGKAtJZrv9EpQagef
BorisTyshkevich
merged commit 5a39b5c
into
feat/result-header-names-only
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor toolbar + Saved/History UX improvements from the original design. Stacked on #6 (base = its branch); retarget to main once #6 merges.
Editor toolbar
formatQuery(same action as ⌘⇧Enter).Save flow
Saved list
History list
Code
state.js:saveQuery(create-or-update + link),savedForTab,renameSaved,toggleFavorite,sortedSavedreplacetoggleSaved/findSavedBySql.icons.js: braces, bookmark, pencil, trash.shortcuts.js: ⌘S opens the popover.Verified live on otel: Format/Save buttons, popover prefill + commit, button → "Saved", live count, pencil inline-rename, trash, History trash.
Tests
npm test→ 381 passing; state.js / saved-history.js / shortcuts.js / icons.js at 100%, app.js meets its gate.Generated with Claude Code
https://claude.ai/code/session_01QennTvGKAtJZrv9EpQagef