Skip to content

Antalya 26.5: Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvonand wants to merge 2 commits into
base: antalya-26.5
Choose a base branch
from
Open

Antalya 26.5: Support Nullable(Tuple) for Arrow, ArrowStream, ORC, legacy Parquet formats #1976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538868c
Cherry-pick of https://github.com/Altinity/ClickHouse/pull/1802 with …
zvonand May 21, 2026
cb46867
Resolve conflicts in cherry-pick of #1802
zvonand Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Processors/Formats/Impl/MsgPackRowInputFormat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,11 +401,6 @@ bool MsgPackVisitor::start_array(size_t size) // NOLINT
}
else if (isTuple(removeNullable(info_stack.top().type)))
{
const auto & tuple_type = assert_cast<const DataTypeTuple &>(*removeNullable(info_stack.top().type));
const auto & nested_types = tuple_type.getElements();
if (size != nested_types.size())
throw Exception(ErrorCodes::ILLEGAL_COLUMN, "Cannot insert MessagePack array with size {} into Tuple column with {} elements", size, nested_types.size());

/// If the type is Nullable, reaching start_array means the value
/// is non-null (for nulls, the parser calls visit_nil instead).
/// So we can safely unwrap the Nullable to work with the inner
Expand All @@ -418,6 +413,11 @@ bool MsgPackVisitor::start_array(size_t size) // NOLINT
column_ptr = &nullable_column.getNestedColumn();
}

const auto & tuple_type = assert_cast<const DataTypeTuple &>(*removeNullable(info_stack.top().type));
const auto & nested_types = tuple_type.getElements();
if (size != nested_types.size())
throw Exception(ErrorCodes::ILLEGAL_COLUMN, "Cannot insert MessagePack array with size {} into Tuple column with {} elements", size, nested_types.size());

ColumnTuple & column_tuple = assert_cast<ColumnTuple &>(*column_ptr);
/// Push nested columns into stack in reverse order.
for (ssize_t i = static_cast<ssize_t>(nested_types.size()) - 1; i >= 0; --i)
Expand Down
Loading