Antalya 26.5: Antalya 26.3 port - Fix view over iceberg (+ cluster-requests prereq #1687)#1955
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.5: Antalya 26.3 port - Fix view over iceberg (+ cluster-requests prereq #1687)#1955zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…iceberg Antalya 26.3: Fix view over iceberg
zvonand
added
releasy
ianton-ru
requested changes
Jun 29, 2026
| extern const SettingsBool table_engine_read_through_distributed_cache; | ||
| extern const SettingsUInt64 s3_path_filter_limit; | ||
| extern const SettingsBool use_parquet_metadata_cache; | ||
| extern const SettingsBool input_format_parquet_use_native_reader_v3; |
There was a problem hiding this comment.
input_format_parquet_use_native_reader_v3 is from some other change, I guess it can be removed.
|
|
||
| bool not_a_path = false; | ||
|
|
||
| while (true) |
There was a problem hiding this comment.
Usage of not_a_path is lost. In #1687 this flag was an additional condition to exit from cycle, need something like while (not_a_path) here.
There was a problem hiding this comment.
See also #1953, where while is changed on do ... while
There was a problem hiding this comment.
Actually it was changed in upstream fromdo .. while on while in ClickHouse#102115
27 tasks
zvonand
changed the title
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect work view over Iceberg table (#1950 by @zvonand, #1759 by @ianton-ru).
CI/CD Options
Exclude tests:
Regression jobs to run:
Combined port of 2 PR(s) (group
pr-1759). Cherry-picked from #1950, #1759.