test: add release-validation coverage for post-v0.8.7 merged PRs#952
Conversation
Adds regression tests for the 8 PRs merged since `v0.8.7`, authored during
pre-release validation. Two independent authoring passes (suffix `-codex.test.ts`
from the codex CLI track, plus `release-validation/*.test.ts` from the Claude
multi-agent track) intentionally overlap to maximize edge-case coverage.
opencode (`packages/opencode/test/release-validation/`):
- `question-937*` non-interactive question tool: `ALTIMATE_NON_INTERACTIVE`
/ `ALTIMATE_FORCE_INTERACTIVE` / `ALTIMATE_AUTO_ANSWER`
matrix, output-text contract, `run.ts`/`bash.ts` env guards
- `mcp-datamate-893*` MCP config normalize/merge, enabled-state persistence,
recursive `**/mcp.json` discovery, datamate transport selection
- `session-transcript-941*` transcript REST endpoint: query coercion, content negotiation,
tool/thinking detail gating, error schema
- `serve-upgrade-940*` headless `serve` startup upgrade check: scheduling, failure
isolation, version-compare boundaries
- `serve-trace-log-929*` trace-directory startup logging
- `chunk-timeout-844*` `DEFAULT_CHUNK_TIMEOUT` SSE watchdog behavior
- `windows-installer-930*` `install.ps1` static analysis (HTTPS URLs, error handling,
PATH safety, idempotency, no secret leakage) + win32 dispatch
dbt-tools (`packages/dbt-tools/test/`):
- `dbt-cli-release-validation.test.ts` #933 error-bubbling: malformed JSON, exit-code
redaction, ANSI stripping, no-signal fallback
- `dbt-cli-extra-codex.test.ts` result-shape, `--limit` boundaries, last-error
selection, inline-compile error paths
All new tests pass and are typecheck-clean. 4 `test.todo` markers document real,
pre-existing edge cases surfaced during review (transcript path-traversal -> 500,
`normalizeMcpConfig` dropping `updatedAt`, `install.ps1` missing archive checksum,
`execDbtCompile` stale-manifest fallback). No source files are modified.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughAdds thirteen new Bun test files as release-validation regression coverage for eight previously merged PRs ( Changesdbt-cli regression tests (PR
Provider SSE chunk-timeout regression tests (PR
MCP/Datamate IDE-aware transport and config sync regression tests (PR
QuestionTool non-interactive and auto-answer regression tests (PR
Serve startup tracing and upgrade-check regression tests (PRs
Session transcript endpoint regression tests (PR
Windows PowerShell installer regression tests (PR
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
PINEAPPLE
What does this PR do?
Adds regression test coverage for the 8 PRs merged since
v0.8.7, authored during pre-release validation. No source files are modified — tests only.Two independent authoring passes intentionally overlap to maximize edge-case coverage:
*-codex.test.ts— codex CLI trackrelease-validation/*.test.ts— Claude multi-agent trackopencode (
packages/opencode/test/release-validation/):question-937*(fix: auto-resolve question tool in non-interactive contexts #937) — non-interactive question tool:ALTIMATE_NON_INTERACTIVE/ALTIMATE_FORCE_INTERACTIVE/ALTIMATE_AUTO_ANSWERmatrix, output-text contract,run.ts/bash.tsenv guardsmcp-datamate-893*(feat: IDE-aware datamate transport, enabled-state persistence, and /mcps command #893) — MCP config normalize/merge, enabled-state persistence, recursive**/mcp.jsondiscovery, datamate transport selectionsession-transcript-941*(feat: [AI-6949] add session transcript REST endpoint for datamates extension #941) — transcript REST endpoint: query coercion, content negotiation, tool/thinking detail gating, error schemaserve-upgrade-940*(fix: trigger auto-update check on headlessservestartup #940) — headlessservestartup upgrade check: scheduling, failure isolation, version-compare boundariesserve-trace-log-929*(serve: log trace output directory on startup #929) — trace-directory startup loggingchunk-timeout-844*(fix: increase DEFAULT_CHUNK_TIMEOUT from 2min to 5min #844) —DEFAULT_CHUNK_TIMEOUTSSE watchdog behaviorwindows-installer-930*(feat: Windows PowerShell installer (install.ps1) #930) —install.ps1static analysis (HTTPS URLs, error handling, PATH safety, idempotency, no secret leakage) + win32 dispatchdbt-tools (
packages/dbt-tools/test/):dbt-cli-release-validation.test.ts(fix: bubble real dbt show error instead of generic "Could not parse" #933) — error-bubbling: malformed JSON, exit-code redaction, ANSI stripping, no-signal fallbackdbt-cli-extra-codex.test.ts(fix: bubble real dbt show error instead of generic "Could not parse" #933) — result shape,--limitboundaries, last-error selection, inline-compile error paths4
test.todomarkers document real, pre-existing edge cases surfaced during review (do not block release): transcript path-traversal → 500,normalizeMcpConfigdroppingupdatedAt,install.ps1missing archive checksum,execDbtCompilestale-manifest fallback.Type of change
Issue for this PR
Closes #951
How did you verify your code works?
bun turbo typecheck— green (all 7 packages, forced/no-cache)cd packages/opencode && bun test test/release-validation/— 172 pass / 3 todo / 0 fail (12 files)cd packages/dbt-tools && bun test test/dbt-cli-extra-codex.test.ts test/dbt-cli-release-validation.test.ts— 18 pass / 1 todo / 0 failcd packages/dbt-tools && bun run test(full suite, regression check) — 82 pass / 0 failChecklist
Summary by cubic
Adds regression tests for the 8 PRs merged since
v0.8.7to strengthen release validation; no source files are changed. Addresses #951. Two overlapping tracks (*-codex.test.tsandrelease-validation/*.test.ts) maximize edge-case coverage.packages/opencode: non-interactivequestiontool env matrix and output contract; MCP/datamate config normalize/merge, discovery, and transport selection; session transcript API (query coercion, content negotiation, detail gating, error schema); serve startup upgrade check (scheduling, failure isolation, version compare) and trace-dir logging; provider SSE chunk-timeout default; Windowsinstall.ps1safety and native win32 upgrade dispatch.packages/dbt-tools:dbt-clierror bubbling (malformed JSON, exit-code redaction, ANSI stripping, no-signal fallback) and result shape/--limit/inline-compile paths.4 test.todo markers document known, pre-existing gaps and do not block the release.
Written for commit a8a08c6. Summary will update on new commits.
Summary by CodeRabbit