Added Lattice extraction support for MomentumSpace#145
Merged
Conversation
MomentumSpace.extract(Lattice) now returns the direct lattice dual to the space's unique reciprocal lattice. This reuses the existing reciprocal-lattice extraction path, so empty spaces and mixed reciprocal lattices still raise the same validation errors. Tests were added to cover successful lattice extraction and the existing failure modes.
…tice and dual lattice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #143
Description
MomentumSpace.extract(Lattice)now returns the direct lattice dual to the space's unique reciprocal lattice. This reuses the existing reciprocal-lattice extraction path, so empty spaces and mixed reciprocal lattices still raise the same validation errors. Tests were added to cover successful lattice extraction and the existing failure modes.