Skip to content

Conversation

@RosCraddock
Copy link

Based on the same pedigree, provided simple examples considered in the 24/10 meeting as requested in #7. Additional text towards drafting the founders vignette, but still a work in progress.

Draft of first part of founder.rmd with simple example covering multiple scenarios
@gregorgorjanc
Copy link
Member

@RosCraddock will have a look. See what I have done in 2f49d7f regarding demonstrating how partitioning works - I know you are planning to do something similar for the metafounders.

@gregorgorjanc
Copy link
Member

The devel version now has a very nicely worked out example in the introduction (see

\begin{align*}
) and I have also included a new unit test based on this example (see
test_that("Test computation - 2nd example", {
).

I think it would be instructive to do similar for the UPG/metafounder example(s) you are working with. Perhaps you don't do all the examples at this level of detail.

@RosCraddock
Copy link
Author

The devel version now has a very nicely worked out example in the introduction (see

\begin{align*}

) and I have also included a new unit test based on this example (see

test_that("Test computation - 2nd example", {

).
I think it would be instructive to do similar for the UPG/metafounder example(s) you are working with. Perhaps you don't do all the examples at this level of detail.

I agree! I intend to walk through one of the examples to demonstrate the theory with including unknown parent groups. I'll refer to the other vignettes to keep consistency.

@gregorgorjanc
Copy link
Member

I agree! I intend to walk through one of the examples to demonstrate the theory with including unknown parent groups. I'll refer to the other vignettes to keep consistency.

I wonder if we need to do it just for one example (for 1 OR 2+ metafounders) or for two (for 1 AND 2+ metafounders)?

I am thinking about this to make it clear how we deal non-zero mean(s) of the base population when there is 1 or 2+ metafounders. Need to implement that table we have developed on the wall to clarify my mind about this;)

- More detail and theoretic justification.
@RosCraddock
Copy link
Author

I wonder if we need to do it just for one example (for 1 OR 2+ metafounders) or for two (for 1 AND 2+ metafounders)?

I am thinking about this to make it clear how we deal non-zero mean(s) of the base population when there is 1 or 2+ metafounders. Need to implement that table we have developed on the wall to clarify my mind about this;)

I just added the theory to the Founders.rmd. I followed your example from the intro for one unknown parent group and provide similar context for multiple unknown parent groups (but not as detailed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants