Bugfix/issue42 #607
Open
Bugfix/issue42 #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell clang to compile against the C++11 standard
Replaced #errors in __APPLE__ ifdefs to simply no-op. A proper implementation will need some work to interface with CoreAudio on the Mac which will require some c++ to Obj-C bridging which I don’t know how to do yet.
More clang combat. Added set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}
-Wno-inconsistent-missing-override")
Should make it easier to spot actual clang errors.
Everything appears to work anyway!
the mBackgroundOverlay setImage call was causing a later call to an OpenGL method before SDL had been asked to init OpenGL on Mac OS X
e.g. static std::vector<std::shared_ptr<Sound> > sSoundVector;
Generally a good idea to ignore dot files, but especially important on OS X which spews ._SomeFile files on filesystems which do not natively support HFS+ metadata streams
Oops. Left some cruft behind in dotfile exclusion.
Fixes issue Aloshi#349
MacOS Support (Thanks @displaced!)
MVC2015 & Sorting (Thanks @aslater!)
Initial commit for allowing hidden files
The old implementation hardcoded a the directory ~/.emulationstation everywhere. This implementation uses compiler flags to find a sensible location (XDG compliant on linux, My Documents on Windows, and either XDG or Application Support on OSX)
Since I've wanted to build on OSX I had to dummy out or implement for the OSX compiler flags. I plan on using SDL to do manual mixing so I removed the rest too.
I basically made clang happy, there are still warnings for literal string compares which I will fix soon. There was also the problem on calling GL functions before it was initialized.
Proper shutdown and restart on linux
Added symlink support on removeCommonPath
Add SDL2 to brew install list for compiling on OSX
Update README.md with SDL2 brew for OSX
Also fixed a bug with both options.
Merging RetroPie Branch
Currently, this requires you to restart ES to take effect.
Preprocessor checks for Visual Studio broke the GCC6 build, fixed
Bug in checking for config files.
…ion runs under the right permissions !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue 42, OS will now restart and shutdown