feat(codegen): add dry-run registry + codegen management command#117
Merged
davecoates merged 1 commit intomainfrom Feb 26, 2026
Merged
feat(codegen): add dry-run registry + codegen management command#117davecoates merged 1 commit intomainfrom
davecoates merged 1 commit intomainfrom
Conversation
davecoates
force-pushed
the
feature/issue114-codegen-command
branch
from
e59d384 to
498bc3a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 79.24% 81.22% +1.97%
==========================================
Files 93 94 +1
Lines 6554 6646 +92
==========================================
+ Hits 5194 5398 +204
+ Misses 1360 1248 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
micahklaz
approved these changes
Feb 26, 2026
Collaborator
micahklaz
left a comment
micahklaz
left a comment
There was a problem hiding this comment.
Approved as the comment might not be a deal-breaker
| if dry_run: | ||
| stats.files_pending.append(intermediate_file.target_path) | ||
| else: | ||
| stats.files_written.append(intermediate_file.target_path) |
Collaborator
There was a problem hiding this comment.
I think appending to files written after actually writing made more sense - that way if the writing process goes wrong (e.g. permission error) then the file path won't mistakenly be added to the list of files written.
Contributor
Author
There was a problem hiding this comment.
Makes sense, have moved it after
Includes dry-run support, new REGISTRY setting/command. Resolves #114
davecoates
force-pushed
the
feature/issue114-codegen-command
branch
from
498bc3a to
a033053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes dry-run support, new REGISTRY setting/command.
Resolves #114