Skip to content

feat: adds metadata check #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtyoung84 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: adds metadata check #263

jtyoung84 wants to merge 1 commit into from

Conversation

@jtyoung84
Copy link
Collaborator

@jtyoung84 jtyoung84 commented Aug 8, 2023

Closes AllenNeuralDynamics/aind-data-schema#546

  • Adds check in basic upload job to verify metadata files are found either in a dedicated metadata folder the user defines, or the parent of the first modality folder
  • Uses AindCoreModel's default_filename() to figure out the json file names to check
  • Adds check on ecephys and smartspim run through basic upload job api
  • Adds unit tests

@jtyoung84 jtyoung84 marked this pull request as draft August 8, 2023 00:18
@jtyoung84 jtyoung84 marked this pull request as ready for review August 9, 2023 16:25
@jtyoung84 jtyoung84 requested a review from dyf August 9, 2023 16:25
@mekhlakapoor
Copy link
Contributor

mekhlakapoor commented Jun 14, 2024

@jtyoung84 @dyf The linked issue is already marked as closed. Can we close this PR?

@mekhlakapoor
Copy link
Contributor

mekhlakapoor commented Jul 19, 2024

Can this PR be closed @jtyoung84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyf dyf Awaiting requested review from dyf

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

metadata completeness check for ecephys data

3 participants

@jtyoung84 @mekhlakapoor