Conversation
jsiegle
left a comment
jsiegle
left a comment
There was a problem hiding this comment.
I think a union of a detector and MIS module is all we need, so this looks good!
| """Configuration for a camera used in a New Scale modular insertion system""" | ||
|
|
||
| detector_config: DetectorConfig = Field(..., title="Detector configuration") | ||
| module: MISModuleConfig = Field(..., title="Module") |
There was a problem hiding this comment.
doesn't this need the ManipulatorConfig?
There was a problem hiding this comment.
@jsiegle I don't think the cameras are mounted on a manipulator, are they, or is it possible for them to be?
There was a problem hiding this comment.
No, there's no manipulator on these modules. Just a camera+lens on an arc with A/P and M/L angles.
There was a problem hiding this comment.
Do you want to be able to save the actual rotation/translation of the camera, we can include device positioning information here. Alternatively we can just include the MIS module arc angles if it's not possible to get the accurate transform.
There was a problem hiding this comment.
Can you add an optional Transform so we can track this if needed?
3 participants
PR adds a new assembly configuration combining a DetectorConfig and a MISModuleConfig, for mounted cameras on the New Scale MIS system.