refactor: pull TZ information out of acquisition_start_time#1714
Merged
refactor: pull TZ information out of acquisition_start_time#1714
Conversation
dbirman
force-pushed
the
1689-acquisitionacquisition_start_tz
branch
from
10bb4f3 to
9f04ce8
Compare
dyf
approved these changes
Feb 3, 2026
saskiad
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional field
Acquisition.acquisition_start_tzthat is populated from a validator by pulling the timezone information out of theacquisition_start_timefield. The validator runs in "after" mode because if a user passes a naive datetime it gets auto-coerced during object construction by theAwareDatetimeWithDefaultclass and we need to wait for that to happen.